linux-kernel - [PATCH 1/5] block, bfq: remove unnecessary meta

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed,  2 Nov 2022 19:43:50 +0800
From:   Yuwei Guan <ssawgyw@...il.com>
To:     paolo.valente@...aro.org, axboe@...nel.dk, tj@...nel.org,
        josef@...icpanda.com
Cc:     linux-block@...r.kernel.org, cgroups@...r.kernel.org,
        linux-kernel@...r.kernel.org, Yuwei.Guan@...krlife.com
Subject: [PATCH 1/5] block, bfq: remove unnecessary meta_pending count

The meta_pending is counted only, but no one use it,
so remove it.

Signed-off-by: Yuwei Guan <Yuwei.Guan@...krlife.com>
---
 block/bfq-iosched.c | 7 -------
 block/bfq-iosched.h | 2 --
 2 files changed, 9 deletions(-)

diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
index 7ea427817f7f..74b87694105f 100644
--- a/block/bfq-iosched.c
+++ b/block/bfq-iosched.c
@@ -2448,10 +2448,6 @@ static void bfq_remove_request(struct request_queue *q,
 		if (unlikely(!bfqd->nonrot_with_queueing))
 			bfq_pos_tree_add_move(bfqd, bfqq);
 	}
-
-	if (rq->cmd_flags & REQ_META)
-		bfqq->meta_pending--;
-
 }
 
 static bool bfq_bio_merge(struct request_queue *q, struct bio *bio,
@@ -5975,9 +5971,6 @@ static void bfq_update_has_short_ttime(struct bfq_data *bfqd,
 static void bfq_rq_enqueued(struct bfq_data *bfqd, struct bfq_queue *bfqq,
 			    struct request *rq)
 {
-	if (rq->cmd_flags & REQ_META)
-		bfqq->meta_pending++;
-
 	bfqq->last_request_pos = blk_rq_pos(rq) + blk_rq_sectors(rq);
 
 	if (bfqq == bfqd->in_service_queue && bfq_bfqq_wait_request(bfqq)) {
diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h
index 71f721670ab6..3de849e97e4e 100644
--- a/block/bfq-iosched.h
+++ b/block/bfq-iosched.h
@@ -268,8 +268,6 @@ struct bfq_queue {
 	struct request *next_rq;
 	/* number of sync and async requests queued */
 	int queued[2];
-	/* number of pending metadata requests */
-	int meta_pending;
 	/* fifo list of requests in sort_list */
 	struct list_head fifo;
 
-- 
2.34.1