linux-kernel - Re: [PATCH v2 2/3] block: Correct comment for scale_cookie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y2J6pPj4/aVdoGPp@localhost.localdomain>
Date:   Wed, 2 Nov 2022 10:11:48 -0400
From:   Josef Bacik <josef@...icpanda.com>
To:     Kemeng Shi <shikemeng@...wei.com>
Cc:     tj@...nel.org, axboe@...nel.dk, cgroups@...r.kernel.org,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] block: Correct comment for scale_cookie_change

On Tue, Oct 18, 2022 at 07:12:39PM +0800, Kemeng Shi wrote:
> Default queue depth of iolatency_grp is unlimited, so we scale down
> quickly(once by half) in scale_cookie_change. Remove the "subtract
> 1/16th" part which is not the truth and add the actual way we
> scale down.
> 
> Signed-off-by: Kemeng Shi <shikemeng@...wei.com>

This is perfect, thanks Kemeng

Reviewed-by: Josef Bacik <josef@...icpanda.com>

Thanks,

Josef