linux-kernel - Re: [PATCH v2] io_uring: fix two assignments in if conditions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <630269a9-29a3-6b75-0a67-449ec36e7e5e@kernel.dk>
Date:   Wed, 2 Nov 2022 08:19:19 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     korantwork@...il.com, asml.silence@...il.com
Cc:     linux-kernel@...r.kernel.org, io-uring@...r.kernel.org,
        Xinghui Li <korantli@...cent.com>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v2] io_uring: fix two assignments in if conditions

On 11/2/22 2:25 AM, korantwork@...il.com wrote:
> From: Xinghui Li <korantli@...cent.com>
> 
> Fixs two error:
> 
> "ERROR: do not use assignment in if condition
> 130: FILE: io_uring/net.c:130:
> +       if (!(issue_flags & IO_URING_F_UNLOCKED) &&
> 
> ERROR: do not use assignment in if condition
> 599: FILE: io_uring/poll.c:599:
> +       } else if (!(issue_flags & IO_URING_F_UNLOCKED) &&"
> reported by checkpatch.pl in net.c and poll.c .

I'm not super excited about this patch as the previous one
wasn't even compiled? Did you test this one, compile and runtime?

-- 
Jens Axboe