linux-kernel - Re: [PATCH] media: stv0288: use explicitly signed char

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHmME9qMqUyNp2bdoY1YH14yvhZAwE_oAC5tav9jbTGp0jeUpA@mail.gmail.com>
Date:   Wed, 2 Nov 2022 03:47:01 +0100
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: stv0288: use explicitly signed char

Hi Mauro,

On Mon, Oct 24, 2022 at 6:28 PM Jason A. Donenfeld <Jason@...c4.com> wrote:
>
> With char becoming unsigned by default, and with `char` alone being
> ambiguous and based on architecture, signed chars need to be marked
> explicitly as such. Use `s8` and `u8` types here, since that's what
> surrounding code does. This fixes:
>
> drivers/media/dvb-frontends/stv0288.c:471 stv0288_set_frontend() warn: assigning (-9) to unsigned variable 'tm'
> drivers/media/dvb-frontends/stv0288.c:471 stv0288_set_frontend() warn: we never enter this loop
>
> Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
> Cc: linux-media@...r.kernel.org
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>

Was wondering whether you planned on taking this into your tree as a
6.1 fix for Linus for rc4?

Thanks,
Jason