linux-kernel - Re: [PATCH] spi: nxp-fspi: make const array ls1028a_soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221102161857.7t7dqipgfsh2cgtf@umbrella>
Date:   Wed, 2 Nov 2022 11:19:17 -0500
From:   Han Xu <han.xu@....com>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     Haibo Chen <haibo.chen@....com>,
        Yogesh Gaur <yogeshgaur.83@...il.com>,
        Mark Brown <broonie@...nel.org>, linux-spi@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: nxp-fspi: make const array ls1028a_soc_attr static

On 22/11/02 03:29PM, Colin Ian King wrote:
> Don't populate the const array ls1028a_soc_attr on the stack, instead
> make it static. Also makes the object code smaller.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>  drivers/spi/spi-nxp-fspi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c
> index d6a65a989ef8..1c1991a26c15 100644
> --- a/drivers/spi/spi-nxp-fspi.c
> +++ b/drivers/spi/spi-nxp-fspi.c
> @@ -924,7 +924,7 @@ static int nxp_fspi_adjust_op_size(struct spi_mem *mem, struct spi_mem_op *op)
>  
>  static void erratum_err050568(struct nxp_fspi *f)
>  {
> -	const struct soc_device_attribute ls1028a_soc_attr[] = {
> +	static const struct soc_device_attribute ls1028a_soc_attr[] = {
>  		{ .family = "QorIQ LS1028A" },
>  		{ /* sentinel */ }
>  	};

Acked-by: Han Xu <han.xu@....com>

> -- 
> 2.37.3
>