linux-kernel - Re: [PATCH v5 RESEND] soc: nuvoton: Add SoC info driver for WPCM450

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 3 Nov 2022 16:45:04 +0100
From:   Jonathan Neuschäfer <j.neuschaefer@....net>
To:     Tomer Maimon <tmaimon77@...il.com>
Cc:     Joel Stanley <joel@....id.au>,
        Jonathan Neuschäfer <j.neuschaefer@....net>,
        Hitomi Hasegawa <hasegawa-hitomi@...itsu.com>,
        Paul Menzel <pmenzel@...gen.mpg.de>,
        Hector Martin <marcan@...can.st>,
        Arnd Bergmann <arnd@...db.de>, Sven Peter <sven@...npeter.dev>,
        openbmc@...ts.ozlabs.org, Brian Norris <briannorris@...omium.org>,
        linux-kernel@...r.kernel.org,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Lubomir Rintel <lkundrak@...sk>,
        Conor Dooley <conor.dooley@...rochip.com>,
        Robert Jarzmik <robert.jarzmik@...e.fr>
Subject: Re: [PATCH v5 RESEND] soc: nuvoton: Add SoC info driver for WPCM450

On Thu, Nov 03, 2022 at 09:11:08AM +0200, Tomer Maimon wrote:
> Hi Jonathan,
> 
> Thanks for your patch.
> 
> On Thu, 3 Nov 2022 at 01:09, Joel Stanley <joel@....id.au> wrote:
> >
> > On Mon, 31 Oct 2022 at 22:40, Jonathan Neuschäfer <j.neuschaefer@....net> wrote:
> > >
> > > Add a SoC information driver for Nuvoton WPCM450 SoCs. It provides
> > > information such as the SoC revision.
[...]
> > > +++ b/drivers/soc/nuvoton/Kconfig
> > > @@ -0,0 +1,11 @@
> > > +# SPDX-License-Identifier: GPL-2.0
> > > +menuconfig WPCM450_SOC
> > > +       tristate "Nuvoton WPCM450 SoC driver"
> > > +       default y if ARCH_WPCM450
> > > +       select SOC_BUS
> >
> > Sorry for not noticing this earlier. This is a bit confusing. If we
> > have a menu option, the soc driver should appear under it. Or we could
> > do without the menu all together, as there's only one driver so far.

Good point.

> >
> > We also should select REGMAP, as you're using it,

I'll add it.

> > and hide the option behind ARCH_WPCM450 || COMPILE_TEST.
> >
> > How about this:
> >
> > if ARCH_WPCM450 || COMPILE_TEST
> These days we working on LPC BPC driver for NPCM7xx and NPCM8xx that
> will be placed in nuvoton soc folder.
> we will use:
> 
> if ARCH_NPCM || COMPILE_TEST
> 
> menu "NPCM SoC drivers"

That sounds reasonable, I'll do something similar.

> Maybe you should remove
> if ARCH_WPCM450 || COMPILE_TEST
> 
> and add ARCH_WPCM450 dependency in the WPCM450_SOCINFO driver configuration.

The WPCM450_SOCINFO driver would build fine on other NPCM SoC, it just
wouldn't be very useful, so I think the current "default y if ARCH_WPCM450"
solution is sufficient.

> 
> >
> > config WPCM450_SOCINFO
> >         tristate "Nuvoton WPCM450 SoC driver"
> >         default y if ARCH_WPCM450
> >         select SOC_BUS
> >         select REGMAP
> >         help
> >           Say Y here to compile the SoC information driver for Nuvoton
> >           WPCM450 SoCs.
> >
> >           This driver provides information such as the SoC model and
> >           revision.
> >
> > endif


Thank you both,
Jonathan

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)