linux-kernel - Re: [PATCH 2/5] zsmalloc: Consolidate zs_pool's migrate_lock and size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2Pj+fuON8lTMcmn@google.com>
Date:   Thu, 3 Nov 2022 08:53:29 -0700
From:   Minchan Kim <minchan@...nel.org>
To:     Johannes Weiner <hannes@...xchg.org>
Cc:     Sergey Senozhatsky <senozhatsky@...omium.org>,
        Nhat Pham <nphamcs@...il.com>, akpm@...ux-foundation.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        ngupta@...are.org, sjenning@...hat.com, ddstreet@...e.org,
        vitaly.wool@...sulko.com
Subject: Re: [PATCH 2/5] zsmalloc: Consolidate zs_pool's migrate_lock and
 size_class's locks

On Thu, Nov 03, 2022 at 11:18:04AM -0400, Johannes Weiner wrote:
> On Wed, Nov 02, 2022 at 02:36:35PM -0700, Minchan Kim wrote:
> > On Wed, Nov 02, 2022 at 12:28:56PM +0900, Sergey Senozhatsky wrote:
> > > On (22/10/26 13:06), Nhat Pham wrote:
> > > >  struct size_class {
> > > > -	spinlock_t lock;
> > > >  	struct list_head fullness_list[NR_ZS_FULLNESS];
> > > >  	/*
> > > >  	 * Size of objects stored in this class. Must be multiple
> > > > @@ -247,8 +245,7 @@ struct zs_pool {
> > > >  #ifdef CONFIG_COMPACTION
> > > >  	struct work_struct free_work;
> > > >  #endif
> > > > -	/* protect page/zspage migration */
> > > > -	rwlock_t migrate_lock;
> > > > +	spinlock_t lock;
> > > >  };
> > > 
> > > I'm not in love with this, to be honest. One big pool lock instead
> > > of 255 per-class locks doesn't look attractive, as one big pool lock
> > > is going to be hammered quite a lot when zram is used, e.g. as a regular
> > > block device with a file system and is under heavy parallel writes/reads.
> 
> TBH the class always struck me as an odd scope to split the lock. Lock
> contention depends on how variable the compression rate is of the
> hottest incoming data, which is unpredictable from a user POV.
> 
> My understanding is that the primary usecase for zram is swapping, and
> the pool lock is the same granularity as the swap locking.

People uses the zram to store caching object files in build server.

> 
> Regardless, we'll do some benchmarks with filesystems to understand
> what a reasonable tradeoff would be between overhead and complexity.

Thanks.

> Do you have a particular one in mind? (I'm thinking journaled ones are
> not of much interest, since their IO tends to be fairly serialized.)
> 
> btrfs?

I am not sure what FSes others are using but at least for me, just
plain ext4.

> 
> > I am also worry about that LRU stuff should be part of allocator
> > instead of higher level.
> 
> I'm sorry, but that's not a reasonable objection.
> 
> These patches implement a core feature of being a zswap backend, using
> standard LRU and locking techniques established by the other backends.
> 
> I don't disagree that it would nicer if zswap had a strong abstraction
> for backend pages and a generalized LRU. But that is major surgery on
> a codebase of over 6,500 lines. It's not a reasonable ask to change
> all that first before implementing a basic feature that's useful now.

With same logic, folks added the LRU logic into their allocators
without the effort considering moving the LRU into upper layer.

And then trend is still going on since I have seen multiple times
people are trying to add more allocators. So if it's not a reasonable
ask to consier, we couldn't stop the trend in the end.

> 
> I get that your main interest is zram, and so this feature isn't of
> interest to you. But zram isn't the only user, nor is it the primary

I am interest to the feature but my interest is more of general swap
layer to manage the LRU so that it could support any hierarchy among
swap devices, not only zswap.