linux-kernel - Re: [PATCH] mm: hugetlb_vmemmap: include missing linux/moduleparam.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Nov 2022 10:51:59 +0800
From:   Muchun Song <muchun.song@...ux.dev>
To:     Vasily Gorbik <gor@...ux.ibm.com>
Cc:     Muchun Song <songmuchun@...edance.com>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Gerald Schaefer <gerald.schaefer@...ux.ibm.com>,
        Linux Memory Management List <linux-mm@...ck.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: hugetlb_vmemmap: include missing linux/moduleparam.h



> On Nov 3, 2022, at 02:09, Vasily Gorbik <gor@...ux.ibm.com> wrote:
> 
> The kernel test robot reported build failures with a 'randconfig' on s390:
>>> mm/hugetlb_vmemmap.c:421:11: error: a function declaration without a
> prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
>   core_param(hugetlb_free_vmemmap, vmemmap_optimize_enabled, bool, 0);
>             ^
> 
> Link: https://lore.kernel.org/linux-mm/202210300751.rG3UDsuc-lkp@intel.com/
> Reported-by: kernel test robot <lkp@...el.com>
> Fixes: 30152245c63b ("mm: hugetlb_vmemmap: replace early_param() with core_param()")

Thanks for your fixing. However, the correct commit that should be fixed is
42deddf3ef5c ("s390: select ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP").

Reviewed-by: Muchun Song <songmuchun@...edance.com>