linux-kernel - Re: [PATCH v8 5/7] KVM: selftests: Shorten the test args in memslot_modification_stress

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2MIVxzVQkGcEwlL@google.com>
Date:   Thu, 3 Nov 2022 00:16:23 +0000
From:   Sean Christopherson <seanjc@...gle.com>
To:     Vipin Sharma <vipinsh@...gle.com>
Cc:     pbonzini@...hat.com, dmatlack@...gle.com, andrew.jones@...ux.dev,
        wei.w.wang@...el.com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 5/7] KVM: selftests: Shorten the test args in
 memslot_modification_stress_test.c

On Wed, Nov 02, 2022, Sean Christopherson wrote:
> On Wed, Nov 02, 2022, Vipin Sharma wrote:
> > Change test args memslot_modification_delay and nr_memslot_modifications
> > to delay and nr_iterations for simplicity.
> 
> Suggested-by: Sean Christopherson <seanjc@...gle.com>
> 
> I don't care about the credit so much as I don't want you getting yelled at for
> one of my random ideas :-)
> 
> > Signed-off-by: Vipin Sharma <vipinsh@...gle.com>
> > ---
> >  .../kvm/memslot_modification_stress_test.c     | 18 +++++++++---------
> >  1 file changed, 9 insertions(+), 9 deletions(-)
> > 
> > diff --git a/tools/testing/selftests/kvm/memslot_modification_stress_test.c b/tools/testing/selftests/kvm/memslot_modification_stress_test.c
> > index d7ddc8a105a2..d6089ccaa484 100644
> > --- a/tools/testing/selftests/kvm/memslot_modification_stress_test.c
> > +++ b/tools/testing/selftests/kvm/memslot_modification_stress_test.c
> > @@ -87,8 +87,8 @@ static void add_remove_memslot(struct kvm_vm *vm, useconds_t delay,
> >  }
> >  
> >  struct test_params {
> > -	useconds_t memslot_modification_delay;
> > -	uint64_t nr_memslot_modifications;
> > +	useconds_t delay;
> > +	uint64_t nr_iterations;
> >  	bool partition_vcpu_memory_access;
> >  };
> >  
> > @@ -107,8 +107,8 @@ static void run_test(enum vm_guest_mode mode, void *arg)
> >  
> >  	pr_info("Started all vCPUs\n");
> >  
> > -	add_remove_memslot(vm, p->memslot_modification_delay,
> > -			   p->nr_memslot_modifications);
> > +	add_remove_memslot(vm, p->delay,
> > +			   p->nr_iterations);
> 
> This wrap is no longer necessary (which was part of the motivation for the
> rename).

Almost forgot.  Nit aside,

Reviewed-by: Sean Christopherson <seanjc@...gle.com>