linux-kernel - Re: [PATCH -next 2/2] PM: hibernate: add check of preallocate mem for image size pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gWBfL4y6RAhDHMx2tbGDFppLJdjb2TFU1aEPn3d+FJqQ@mail.gmail.com>
Date:   Thu, 3 Nov 2022 18:11:22 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     TGSP <tgsp002@...il.com>
Cc:     rafael@...nel.org, len.brown@...el.com, pavel@....cz,
        huanglei@...inos.cn, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, xiongxin <xiongxin@...inos.cn>,
        stable@...r.kernel.org
Subject: Re: [PATCH -next 2/2] PM: hibernate: add check of preallocate mem for
 image size pages

On Tue, Nov 1, 2022 at 3:28 AM TGSP <tgsp002@...il.com> wrote:
>
> From: xiongxin <xiongxin@...inos.cn>
>
> Added a check on the return value of preallocate_image_highmem(). If
> memory preallocate is insufficient, S4 cannot be done;
>
> I am playing 4K video on a machine with AMD or other graphics card and
> only 8GiB memory, and the kernel is not configured with CONFIG_HIGHMEM.
> When doing the S4 test, the analysis found that when the pages get from
> minimum_image_size() is large enough, The preallocate_image_memory() and
> preallocate_image_highmem() calls failed to obtain enough memory. Add
> the judgment that memory preallocate is insufficient;

So I'm not sure what the problem is.  Can you please explain it in more detail?

The if (pages < alloc) appears to be false in your case, so there
should be enough free pages to create an image.

Maybe reserved_size is too low?