linux-kernel - Re: [GIT PULL] Please pull powerpc/linux.git powerpc-6.1-4 tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Nov 2022 10:44:12 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Michael Ellerman <mpe@...erman.id.au>
Cc:     linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        schwab@...ux-m68k.org, palmer@...belt.com,
        linux-riscv@...ts.infradead.org
Subject: Re: [GIT PULL] Please pull powerpc/linux.git powerpc-6.1-4 tag

On Wed, Nov 2, 2022 at 7:09 PM Michael Ellerman <mpe@...erman.id.au> wrote:
>
>  - Fix an endian thinko in the asm-generic compat_arg_u64() which led to syscall arguments
>    being swapped for some compat syscalls.

Am I mis-reading this, or did this bug (introduced in this merge
window by commit 43d5de2b67d7 "asm-generic: compat: Support BE for
long long args in 32-bit ABIs") break *every* architecture?

And people just didn't scream, because 32-bit code has just become so rare?

Or is it just because those compat macros are effectively not used
elsewhere, and x86 has its own versions? Looks like possibly mainly
RISC-V?

Side note: why is it doing

        #ifndef compat_arg_u64

at all? That macro is not actually defined anywhere else, so that
#ifdef seems to be just confused.

                 Linus