linux-kernel - Re: [PATCH v6 1/2] dt-bindings: mfd: Add bindings for MAX5970 and MAX5978

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <613d7971-37d6-c8db-523e-cf3cbdcd5287@linaro.org>
Date:   Thu, 3 Nov 2022 14:01:49 -0400
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Naresh Solanki <naresh.solanki@...ements.com>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        Lee Jones <lee@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Patrick Rudolph <patrick.rudolph@...ements.com>
Cc:     Marcello Sylvester Bauer <sylv@...v.io>
Subject: Re: [PATCH v6 1/2] dt-bindings: mfd: Add bindings for MAX5970 and
 MAX5978

On 03/11/2022 13:53, Naresh Solanki wrote:
> Hi Krzysztof,
> 
> On 03-11-2022 06:43 pm, Krzysztof Kozlowski wrote:
>>> +examples:
>>> +  - |
>>> +    i2c {
>>> +        #address-cells = <1>;
>>> +        #size-cells = <0>;
>>> +        regulator@3a {
>>> +           compatible = "maxim,max5978";
>>> +           reg = <0x3a>;
>>> +           vss1-supply = <&p3v3>;
>>> +
>>> +           regulators {
>>> +               sw0_ref_0: SW0 {
>> No improvements here.
> I've addressed 4 space indentation, bindings are matched, compatible is 
> moved to first, then reg then the rest.

OK, so indeed there are improvements.

Yet still you did not improve the warnings coming from the binding -
this does not match your binding. Test the binding and you will see big
fat warning.

Best regards,
Krzysztof