linux-kernel - Re: [PATCH v1 1/1] cpufreq: ACPI: Use str_enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hzZYdO+U0yrgazZGv243soFv2StB88NZQLr-evs5KreA@mail.gmail.com>
Date:   Thu, 3 Nov 2022 19:12:08 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Viresh Kumar <viresh.kumar@...aro.org>
Subject: Re: [PATCH v1 1/1] cpufreq: ACPI: Use str_enabled_disabled() helper

On Sat, Oct 8, 2022 at 9:52 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> Use str_enabled_disabled() helper instead of open coding the same.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/cpufreq/acpi-cpufreq.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> index 1bb2b90ebb21..8597ab0a84b5 100644
> --- a/drivers/cpufreq/acpi-cpufreq.c
> +++ b/drivers/cpufreq/acpi-cpufreq.c
> @@ -19,6 +19,7 @@
>  #include <linux/compiler.h>
>  #include <linux/dmi.h>
>  #include <linux/slab.h>
> +#include <linux/string_helpers.h>
>
>  #include <linux/acpi.h>
>  #include <linux/io.h>
> @@ -135,8 +136,8 @@ static int set_boost(struct cpufreq_policy *policy, int val)
>  {
>         on_each_cpu_mask(policy->cpus, boost_set_msr_each,
>                          (void *)(long)val, 1);
> -       pr_debug("CPU %*pbl: Core Boosting %sabled.\n",
> -                cpumask_pr_args(policy->cpus), val ? "en" : "dis");
> +       pr_debug("CPU %*pbl: Core Boosting %s.\n",
> +                cpumask_pr_args(policy->cpus), str_enabled_disabled(val));
>
>         return 0;
>  }
> --

Applied as 6.2 material, thanks!