linux-kernel - Re: [PATCH][V2] cpufreq: longhaul: Make array speeds static const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0i4=m1xhVbh10jsFyuHvKBQP3pia0QdONg4bQERR3Ay2g@mail.gmail.com>
Date:   Thu, 3 Nov 2022 19:14:32 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     "Rafael J . Wysocki" <rafael@...nel.org>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        linux-pm@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][V2] cpufreq: longhaul: Make array speeds static const

On Thu, Nov 3, 2022 at 4:04 PM Colin Ian King <colin.i.king@...il.com> wrote:
>
> Don't populate the read-only array speeds on the stack but instead
> make it static. Also makes the object code a little smaller. Replace
> hard-coded loop array bounds with ARRAY_SIZE.
>
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
> V2: replace 4 with ARRAY_SIZE in for-loop as suggested by Joe Perches.
> ---
>  drivers/cpufreq/longhaul.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/longhaul.c b/drivers/cpufreq/longhaul.c
> index 3e000e1a75c6..4c57c6725c13 100644
> --- a/drivers/cpufreq/longhaul.c
> +++ b/drivers/cpufreq/longhaul.c
> @@ -407,10 +407,10 @@ static int guess_fsb(int mult)
>  {
>         int speed = cpu_khz / 1000;
>         int i;
> -       int speeds[] = { 666, 1000, 1333, 2000 };
> +       static const int speeds[] = { 666, 1000, 1333, 2000 };
>         int f_max, f_min;
>
> -       for (i = 0; i < 4; i++) {
> +       for (i = 0; i < ARRAY_SIZE(speeds); i++) {
>                 f_max = ((speeds[i] * mult) + 50) / 100;
>                 f_max += (ROUNDING / 2);
>                 f_min = f_max - ROUNDING;
> --

Applied as 6.2 material, thanks!