linux-kernel - Re: [PATCH net-next v2 1/2] net: hinic: Convert the cmd code from decimal to hex to be more readable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221102203640.1bda5d74@kernel.org>
Date:   Wed, 2 Nov 2022 20:36:40 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Cai Huoqing <cai.huoqing@...ux.dev>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Zhengchao Shao <shaozhengchao@...wei.com>,
        Alexei Starovoitov <ast@...nel.org>,
        SeongJae Park <sj@...nel.org>,
        Peter Chen <peter.chen@...nel.org>,
        Bin Chen <bin.chen@...igine.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 1/2] net: hinic: Convert the cmd code from
 decimal to hex to be more readable

On Tue,  1 Nov 2022 14:03:38 +0800 Cai Huoqing wrote:
> The print cmd code is in hex, so using hex cmd code intead of
> decimal is easy to check the value with print info.

You're still removing empty lines making this patch much harder 
to review. Once again - it should be a pure conversion to dec -> hex.
Don't make any other changes.