linux-kernel - Re: [PATCH] iwlwifi: fix style warnings in iwl-drv.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f933bc0de15a4301e43207fe989e519fa25db31f.camel@sipsolutions.net>
Date:   Thu, 03 Nov 2022 21:52:34 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Linus Probert <linus.probert@...il.com>,
        Gregory Greenman <gregory.greenman@...el.com>,
        Kalle Valo <kvalo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "open list:INTEL WIRELESS WIFI LINK (iwlwifi)" 
        <linux-wireless@...r.kernel.org>,
        "open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iwlwifi: fix style warnings in iwl-drv.c

On Thu, 2022-11-03 at 20:14 +0100, Linus Probert wrote:
> Running checkpatch on iwl-drv.c produced a series of minor style
> warnings. Most of them have been removed. There are some remaining
> regarding multiple lines of quoted strings as well as some warnings
> where the suggested fix produces a new warning.

No thanks.

Some of these really shouldn't be fixed (like strings be broken?! I
thought we stopped this nonsense even in checkpatch), and anyway, this
will probably just cause conflicts for no good reason.

johannes