linux-kernel - Re: [PATCH] arm: dts: imx: e60k02: Add touchscreen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 3 Nov 2022 22:09:22 +0100
From:   Andreas Kemnade <andreas@...nade.info>
To:     Marco Felsch <m.felsch@...gutronix.de>
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
        festevam@...il.com, linux-imx@....com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Alistair Francis <alistair@...stair23.me>
Subject: Re: [PATCH] arm: dts: imx: e60k02: Add touchscreen

Hi Marco,

Am Wed, 26 Oct 2022 19:43:00 +0200
schrieb Marco Felsch <m.felsch@...gutronix.de>:

> Hi Andreas,
> 
> On 22-10-26, Andreas Kemnade wrote:
> > Add the touchscreen now, since the driver is available.  
> 
> I pulled input/next and grep'ed for the compatible but found nothing.
> Where should the driver be available?

now it is in input/next, so time to clean up this one here, too.


> Regards,
>   Marco
> 
> > Signed-off-by: Andreas Kemnade <andreas@...nade.info>
> > ---
> > runtime/dtbs_check depends
> > https://lore.kernel.org/linux-devicetree/20221026114908.191472-1-alistair@alistair23.me/T/#t
> >  arch/arm/boot/dts/e60k02.dtsi              | 12 +++++++++++-
> >  arch/arm/boot/dts/imx6sl-tolino-shine3.dts | 14 ++++++++++++++
> >  arch/arm/boot/dts/imx6sll-kobo-clarahd.dts | 14 ++++++++++++++
> >  3 files changed, 39 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/e60k02.dtsi
> > b/arch/arm/boot/dts/e60k02.dtsi index 935e2359f8df..4f36cc181a52
> > 100644 --- a/arch/arm/boot/dts/e60k02.dtsi
> > +++ b/arch/arm/boot/dts/e60k02.dtsi
> > @@ -104,7 +104,17 @@ &i2c2 {
> >  	clock-frequency = <100000>;
> >  	status = "okay";
> >  
> > -	/* TODO: CYTTSP5 touch controller at 0x24 */
> > +	touchscreen@24 {
> > +		compatible = "cypress,tt21000";
> > +		reg = <0x24>;
> > +		pinctrl-names = "default","sleep";  
> 
> Does the driver handle the different states?
> 
Well, apparently not, just copied it over from vendor kernel driver
which also does not handle that... So just leaving it out for now.

Regards,
Andreas