linux-kernel - Re: [PATCH] staging: r8188eu: remove unused struct declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2aeb10bc-178f-836e-eecd-c77f3eb2f0b5@gmail.com>
Date:   Thu, 3 Nov 2022 22:19:05 +0100
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Deepak R Varma <drv@...lo.com>
Cc:     outreachy@...ts.linux.dev,
        Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Pavel Skripkin <paskripkin@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove unused struct declarations

On 11/3/22 10:47, Deepak R Varma wrote:
> Hello Philipp,
> Thank you for testing the changes.
> 
> Request (not urgent):
> Can you please help me understand how do you
> test such changes? Do we need specific hardware for functional tests? Is there a
> documentation available to know more about the testing? I am interested in
> attaching a physical device to my machine and be able to debug and test the
> changes. Can you please provide details when you have time?
> 
> Thank you in advance!
> ./drv

Hi Deepak,

I do have one device for the following drivers:

vt6656
vt6655
r8188eu
r8192e_pci
r8712u

Minimum test is to measure the transfer speed and see if that is as 
expected.

When I doubt that the changed code is used I use ftrace to see if the 
code is used. But of course I do not test every possibility.

I hope you have the money to be able to buy hardware. Without it is not fun.

I would choose r8188eu (USB) or r8192e_pci.

Bye Philipp