linux-kernel - Re: [PATCH v3 2/3] dt-bindings: watchdog: fsl-imx: document suspend in wait mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d1061af4-cfd6-4c39-e23e-c18d6f2edeea@linaro.org>
Date:   Thu, 3 Nov 2022 18:29:28 -0400
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Rob Herring <robh@...nel.org>,
        Andrej Picej <andrej.picej@...ik.com>
Cc:     linux-watchdog@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, shawnguo@...nel.org,
        devicetree@...r.kernel.org, krzysztof.kozlowski+dt@...aro.org,
        robh+dt@...nel.org, festevam@...il.com,
        linux-kernel@...r.kernel.org, s.hauer@...gutronix.de,
        wim@...ux-watchdog.org, linux@...ck-us.net, kernel@...gutronix.de,
        Anson.Huang@....com, linux-imx@....com
Subject: Re: [PATCH v3 2/3] dt-bindings: watchdog: fsl-imx: document suspend
 in wait mode

On 03/11/2022 08:35, Rob Herring wrote:
> 
> On Thu, 03 Nov 2022 11:03:57 +0100, Andrej Picej wrote:
>> Property "fsl,suspend-in-wait" suspends watchdog in "WAIT" mode which
>> corresponds to Linux's Suspend-to-Idle S0 mode. If this property is not
>> set and the device is put into Suspend-to-Idle mode, the watchdog
>> triggers a reset after 128 seconds.
>>
>> Signed-off-by: Andrej Picej <andrej.picej@...ik.com>
>> Reviewed-by: Fabio Estevam <festevam@...il.com>
>> ---
>> Changes in v3:
>>  - disallow the property for devices which don't support WDW bit
>>    functionality with .yaml DTS allOf:if:then scheme.
>>
>> Changes in v2:
>>  - add a commit message,
>>  - add a list of devices which support this functionality
>> ---
>>  .../bindings/watchdog/fsl-imx-wdt.yaml        | 33 +++++++++++++++++++
>>  1 file changed, 33 insertions(+)
>>
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml:71:1: [error] duplication of key "allOf" in mapping (key-duplicates)
> 

You already have there allOf, so:
1. Move the existing allOf *above* unevaluatedProperties:false (like in
example-schema).
2. Drop the quotes around 'watchdog.yaml', when moving.
3. Add your pieces.

All above in one commit.

Best regards,
Krzysztof