linux-kernel - Re: [PATCH v3 5/7] dt-bindings: watchdog: mediatek: Convert mtk-wdt to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 3 Nov 2022 05:45:07 +0000
From:   Allen-KH Cheng (程冠勳) 
        <Allen-KH.Cheng@...iatek.com>
To:     "nfraprado@...labora.com" <nfraprado@...labora.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
        Project_Global_Chrome_Upstream_Group 
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "wim@...ux-watchdog.org" <wim@...ux-watchdog.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH v3 5/7] dt-bindings: watchdog: mediatek: Convert mtk-wdt
 to json-schema

On Wed, 2022-11-02 at 16:26 -0400, Nícolas F. R. A. Prado wrote:
> On Tue, Nov 01, 2022 at 05:01:14PM +0800, Allen-KH Cheng wrote:
> [..]
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-
> > wdt.yaml
> 
> [..]
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > +    soc {
> > +        #address-cells = <2>;
> > +        #size-cells = <2>;
> > +
> > +        watchdog: watchdog@...07000 {
> 
> You could drop this label since it's not used in the example.
> 
> Reviewed-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
> 
> Thanks,
> Nícolas
> 

Will do.

Thanks,
Allen

> > +            compatible = "mediatek,mt8183-wdt";
> > +            reg = <0 0x10007000 0 0x100>;
> > +            interrupts = <GIC_SPI 139 IRQ_TYPE_LEVEL_LOW>;
> > +            mediatek,disable-extrst;
> > +            timeout-sec = <10>;
> > +            #reset-cells = <1>;
> > +        };
> > +    };
> 
> [..]