linux-kernel - RE: [PATCH] scsi: ufs: Remove check_upiu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Nov 2022 07:04:39 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     "keosung.park@...sung.com" <keosung.park@...sung.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "bvanassche@....org" <bvanassche@....org>,
        "beanhuo@...ron.com" <beanhuo@...ron.com>,
        "adrian.hunter@...el.com" <adrian.hunter@...el.com>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "yoshihiro.shimoda.uh@...esas.com" <yoshihiro.shimoda.uh@...esas.com>,
        "draviv@...eaurora.org" <draviv@...eaurora.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Subject: RE: [PATCH] scsi: ufs: Remove check_upiu_size() from ufshcd.h

> Commit 68078d5cc1a5 ("[SCSI] ufs: Set fDeviceInit flag to initiate device
> initialization") added check_upiu_size(), but no caller.
Nor there ever was.

> 
> Cc: Dolev Raviv <draviv@...eaurora.org>
> Signed-off-by: Keoseong Park <keosung.park@...sung.com>
Reviewed-by: Avri Altman <avri.altman@....com>

> ---
>  include/ufs/ufshcd.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h index
> 96538eb3a6c0..5cf81dff60aa 100644
> --- a/include/ufs/ufshcd.h
> +++ b/include/ufs/ufshcd.h
> @@ -1072,12 +1072,6 @@ void ufshcd_update_evt_hist(struct ufs_hba *hba,
> u32 id, u32 val);  void ufshcd_hba_stop(struct ufs_hba *hba);  void
> ufshcd_schedule_eh_work(struct ufs_hba *hba);
> 
> -static inline void check_upiu_size(void) -{
> -       BUILD_BUG_ON(ALIGNED_UPIU_SIZE <
> -               GENERAL_UPIU_REQUEST_SIZE + QUERY_DESC_MAX_SIZE);
> -}
> -
>  /**
>   * ufshcd_set_variant - set variant specific data to the hba
>   * @hba: per adapter instance
> --
> 2.17.1