linux-kernel - Re: [PATCH v5 1/2] soc: loongson: add GUTS driver for loongson-2 platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <b82c5b2c-d8a3-4b6f-9aad-0a63d2f45f08@app.fastmail.com>
Date:   Thu, 03 Nov 2022 09:53:17 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Yinbo Zhu" <zhuyinbo@...ngson.cn>,
        "Rob Herring" <robh+dt@...nel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
        "Hector Martin" <marcan@...can.st>,
        "Lubomir Rintel" <lkundrak@...sk>,
        "Conor.Dooley" <conor.dooley@...rochip.com>,
        "Linus Walleij" <linus.walleij@...aro.org>,
        "Hitomi Hasegawa" <hasegawa-hitomi@...itsu.com>,
        Heiko Stübner <heiko@...ech.de>,
        "Brian Norris" <briannorris@...omium.org>,
        "Sven Peter" <sven@...npeter.dev>, loongarch@...ts.linux.dev,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/2] soc: loongson: add GUTS driver for loongson-2 platforms

On Thu, Nov 3, 2022, at 09:19, Yinbo Zhu wrote:
> The global utilities block controls PCIE device enabling, alternate
> function selection for multiplexed signals, consistency of HDA, USB
> and PCIE, configuration of memory controller, rtc controller, lio
> controller, and clock control.
>
> This patch adds a driver to manage and access global utilities block
> for loongarch architecture Loongson-2 SoCs. Initially only reading SVR
> and registering soc device are supported. Other guts accesses, such
> as reading PMON configuration by default, should eventually be added
> into this driver as well.
>
> Signed-off-by: Yinbo Zhu <zhuyinbo@...ngson.cn>

Looks ok to me. I can take the new driver through the SoC tree,
so please send it to soc@...nel.org once there are no more
remaining review comments that need to be addressed.

One last thing from my side, with that addressed, please add my

Reviewed-by: Arnd Bergmann <arnd@...db.de>

> +config LOONGSON2_GUTS
> +	tristate "Loongson-2 GUTS"
> +	depends on LOONGARCH || COMPILE_TEST
> +	select SOC_BUS

In the one-line description, please spell out GUTS, since this
is not a generic term but apparently is something that is only
used on Loongarch and Layerscape.

Just for clarification: is this derived from the same IP block
that NXP are using, or is this just coincidentally named
similarly?

      Arnd