linux-kernel - Re: [PATCH 1/3] arm64: exynos: Add new compatible string for Exynos3250 SoC.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3580cfe7-a5a5-e81d-ce45-572b6bf3dde8@samsung.com>
Date:   Thu, 3 Nov 2022 10:24:13 +0100
From:   Marek Szyprowski <m.szyprowski@...sung.com>
To:     Aakarsh Jain <aakarsh.jain@...sung.com>,
        linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Cc:     andrzej.hajda@...el.com, mchehab@...nel.org,
        hverkuil-cisco@...all.nl, ezequiel@...guardiasur.com.ar,
        jernej.skrabec@...il.com, benjamin.gaignard@...labora.com,
        krzysztof.kozlowski+dt@...aro.org, stanimir.varbanov@...aro.org,
        dillon.minfei@...il.com, david.plowman@...pberrypi.com,
        mark.rutland@....com, robh+dt@...nel.org, krzk+dt@...nel.org,
        andi@...zian.org, alim.akhtar@...sung.com,
        aswani.reddy@...sung.com, pankaj.dubey@...sung.com,
        smitha.t@...sung.com
Subject: Re: [PATCH 1/3] arm64: exynos: Add new compatible string for
 Exynos3250 SoC.

Hi

On 02.11.2022 14:06, Aakarsh Jain wrote:
> Exynos3250 uses the same compatible as Exynos5420, but both
> the MFC IPs found in these SoC are different interms of clock
> property. So using same compatible for both SoC is not correct.
> Lets have a separate compatible for Exynos3250 and Exynos5420
> to differentiate these SoCs.
>
> Suggested-by: Alim Akhtar <alim.akhtar@...sung.com>
> Signed-off-by: Aakarsh Jain <aakarsh.jain@...sung.com>

Minor issue, Exynos3250 is based on ARM 32bit not ARM 64bit (see the 
patch subject).

> ---
>   Documentation/devicetree/bindings/media/s5p-mfc.txt | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
> We are already in process of converting this txt file to yaml.
> https://patchwork.kernel.org/project/linux-media/patch/
> 20221011122516.32135-2-aakarsh.jain@...sung.com/
> modifying this txt binding for completeness.
>
> diff --git a/Documentation/devicetree/bindings/media/s5p-mfc.txt b/Documentation/devicetree/bindings/media/s5p-mfc.txt
> index aa54c8159d9f..4ff1898e5a51 100644
> --- a/Documentation/devicetree/bindings/media/s5p-mfc.txt
> +++ b/Documentation/devicetree/bindings/media/s5p-mfc.txt
> @@ -11,9 +11,10 @@ Required properties:
>   	(a) "samsung,mfc-v5" for MFC v5 present in Exynos4 SoCs
>   	(b) "samsung,mfc-v6" for MFC v6 present in Exynos5 SoCs
>   	(c) "samsung,mfc-v7" for MFC v7 present in Exynos5420 SoC
> -	(d) "samsung,mfc-v8" for MFC v8 present in Exynos5800 SoC
> -	(e) "samsung,exynos5433-mfc" for MFC v8 present in Exynos5433 SoC
> -	(f) "samsung,mfc-v10" for MFC v10 present in Exynos7880 SoC
> +	(d) "samsung,exynos3250-mfc" for MFC v7 present in Exynos3250 SoC
> +	(e) "samsung,mfc-v8" for MFC v8 present in Exynos5800 SoC
> +	(f) "samsung,exynos5433-mfc" for MFC v8 present in Exynos5433 SoC
> +	(g) "samsung,mfc-v10" for MFC v10 present in Exynos7880 SoC
>   
>     - reg : Physical base address of the IP registers and length of memory
>   	  mapped region.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland