linux-kernel - Re: [PATCH] sunrpc: svc: Remove unnecessary (void*) conversions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 03 Nov 2022 05:43:55 -0400
From:   Jeff Layton <jlayton@...nel.org>
To:     Li zeming <zeming@...china.com>, chuck.lever@...cle.com,
        trond.myklebust@...merspace.com, anna@...nel.org
Cc:     linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sunrpc: svc: Remove unnecessary (void*) conversions

On Thu, 2022-11-03 at 09:35 +0800, Li zeming wrote:
> The iov_base pointer does not need to cast the type.
> 
> Signed-off-by: Li zeming <zeming@...china.com>
> ---
>  include/linux/sunrpc/svc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
> index daecb009c05b..4b0eead91c94 100644
> --- a/include/linux/sunrpc/svc.h
> +++ b/include/linux/sunrpc/svc.h
> @@ -222,7 +222,7 @@ static inline __be32 svc_getu32(struct kvec *iov)
>  
>  static inline void svc_ungetu32(struct kvec *iov)
>  {
> -	__be32 *vp = (__be32 *)iov->iov_base;
> +	__be32 *vp = iov->iov_base;
>  	iov->iov_base = (void *)(vp - 1);
>  	iov->iov_len += sizeof(*vp);
>  }

Reviewed-by: Jeff Layton <jlayton@...nel.org>