[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <fb9e9d5e-9c8b-1ce2-5723-efa498d1ba93@fi.rohmeurope.com>
Date: Thu, 3 Nov 2022 12:13:50 +0000
From: "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
To: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
Rob Herring <robh@...nel.org>
CC: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
Hans Verkuil <hverkuil-cisco@...all.nl>,
Jacopo Mondi <jacopo@...ndi.org>,
Kieran Bingham <kieran.bingham@...asonboard.com>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Luca Ceresoli <luca@...aceresoli.net>,
Mark Rutland <mark.rutland@....com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Peter Rosin <peda@...ntia.se>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Vladimir Zapolskiy <vz@...ia.com>,
Wolfram Sang <wsa@...-dreams.de>,
"satish.nagireddy@...cruise.com" <satish.nagireddy@...cruise.com>
Subject: Re: [PATCH v4 3/8] dt-bindings: media: add bindings for TI DS90UB960
On 11/3/22 13:50, Tomi Valkeinen wrote:
> Hi Rob,
>
> On 02/11/2022 19:26, Rob Herring wrote:
>> On Tue, Nov 01, 2022 at 03:20:27PM +0200, Tomi Valkeinen wrote:
>>> +
>>> + i2c-alias-pool:
>>
>> Something common or could be? If not, then needs a vendor prefix.
>
> I'll have to think about this. It is related to the i2c-atr, so I think
> it might be a common thing.
I'd say this should be common. Where the i2c-atr properties should live
is another question though. If the I2C-atr stays as a genericly usable
component - then these bindings should be in a file that can be
referenced by other I2C-atr users (like the UB960 here).
// snip
>>> +
>>> + i2c-alias:
>>
>> Vendor prefix.
>>
>>> + description: |
>>> + The i2c address used for the serializer. Transactions
>>> to this
>>> + address on the i2c bus where the deserializer resides are
>>> + forwarded to the serializer.
>>> +
>>> + rx-mode:
>>
>> Vendor prefix. And so on... >
> Yes, I totally missed these.
I think the i2c-alias might need to be common as well?
Best Regards
-- Matti Vaittinen
--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
Powered by blists - more mailing lists