linux-kernel - Re: [PATCH V2 5/5] OPP: decouple dt properties in opp_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <3519763.iIbC2pHGDl@makoto>
Date:   Thu,  3 Nov 2022 22:24:25 +1000
From:   James Calligeros <jcalligeros99@...il.com>
To:     viresh.kumar@...aro.org
Cc:     jcalligeros99@...il.com, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org, nm@...com, rafael@...nel.org,
        sboyd@...nel.org, vincent.guittot@...aro.org, vireshk@...nel.org
Subject: Re: [PATCH V2 5/5] OPP: decouple dt properties in opp_parse_supplies()

On Thursday, 3 November 2022 9:01:08 PM AEST Viresh Kumar wrote:

> @@ -674,7 +677,7 @@ static int opp_parse_supplies(struct dev_pm_opp *opp, struct device *dev,
>  	bool triplet;
>  
>  	microvolt = opp_parse_microvolt(opp, dev, opp_table, &triplet);
> -	if (IS_ERR_OR_NULL(microvolt))
> +	if (IS_ERR(microvolt))
>  		return PTR_ERR(microvolt);

Erroring out here will still block EM registration on platforms without 
the opp-microvolt prop so we're back to square one, which means the 
patch does not do what the description says it does. It behaves
almost identically to the current code.

I assume this is an intentional choice given the comments in
opp_parse_microvolt(), so the commit message should drop 
references to fixing such platforms.

If this is a hard sticking point and opp_parse_supplies() must return
a regulator with opp-microvolt, then I am of the opinion that the parsing
of opp-microwatt should be detangled entirely from the regulator
infrastructure.

Otherwise for the whole series,

Tested-by: James Calligeros <jcalligeros99@...il.com>

- James