linux-kernel - RE: [PATCH v2 0/8] Remove adis_initial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR03MB677857576EF31B737F6D3DF599389@SJ0PR03MB6778.namprd03.prod.outlook.com>
Date:   Thu, 3 Nov 2022 12:35:31 +0000
From:   "Sa, Nuno" <Nuno.Sa@...log.com>
To:     "Bolboaca, Ramona" <Ramona.Bolboaca@...log.com>,
        "jic23@...nel.org" <jic23@...nel.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "Bolboaca, Ramona" <Ramona.Bolboaca@...log.com>
Subject: RE: [PATCH v2 0/8] Remove adis_initial_startup usage

> From: Ramona Bolboaca <ramona.bolboaca@...log.com>
> Sent: Thursday, November 3, 2022 9:09 AM
> To: jic23@...nel.org; linux-iio@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Cc: Bolboaca, Ramona <Ramona.Bolboaca@...log.com>
> Subject: [PATCH v2 0/8] Remove adis_initial_startup usage
> 
> 
> Remove 'adis_initial_startup()' usage due to the fact that it leads to a
> deadlock.
> The same mutex is acquired twice, without releasing it, once inside
> 'adis_initial_startup()' and once inside 'adis_enable_irq()'.
> Instead of 'adis_initial_startup()', use '__adis_initial_startup()'.
> 
> Ramona Bolboaca (8):
>   iio: accel: adis16201: Fix deadlock in probe
>   iio: accel: adis16209: Fix deadlock in probe
>   iio: gyro: adis16136: Fix deadlock in probe
>   iio: gyro: adis16260: Fix deadlock in probe
>   iio: imu: adis16400: Fix deadlock in probe
>   staging: iio: accel: adis16203: Fix deadlock in probe
>   staging: iio: accel: adis16240: Fix deadlock in probe
>   iio: imu: adis: Remove adis_initial_startup function
> 
>  drivers/iio/accel/adis16201.c         |  2 +-
>  drivers/iio/accel/adis16209.c         |  2 +-
>  drivers/iio/gyro/adis16136.c          |  2 +-
>  drivers/iio/gyro/adis16260.c          |  2 +-
>  drivers/iio/imu/adis16400.c           |  2 +-
>  drivers/staging/iio/accel/adis16203.c |  2 +-
>  drivers/staging/iio/accel/adis16240.c |  2 +-
>  include/linux/iio/imu/adis.h          | 12 ------------
>  8 files changed, 7 insertions(+), 19 deletions(-)
> 

You could have placed your v2 changelog in the cover letter.
Moreover it's the same for all patches... Anyways: 

Reviewed-by: Nuno Sá <nuno.sa@...log.com>

- Nuno Sá