linux-kernel - Re: [PATCH] sunrpc: svc: Remove unnecessary (void*) conversions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52658929-14AE-49AB-80DE-F0C68DD29D3D@oracle.com>
Date:   Thu, 3 Nov 2022 13:07:24 +0000
From:   Chuck Lever III <chuck.lever@...cle.com>
To:     Li zeming <zeming@...china.com>
CC:     Jeff Layton <jlayton@...nel.org>,
        Trond Myklebust <trond.myklebust@...merspace.com>,
        Anna Schumaker <anna@...nel.org>,
        Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sunrpc: svc: Remove unnecessary (void*) conversions



> On Nov 3, 2022, at 8:49 AM, Trond Myklebust <trondmy@...nel.org> wrote:
> 
> On Thu, 2022-11-03 at 09:35 +0800, Li zeming wrote:
>> The iov_base pointer does not need to cast the type.
>> 
>> Signed-off-by: Li zeming <zeming@...china.com>
>> ---
>>  include/linux/sunrpc/svc.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
>> index daecb009c05b..4b0eead91c94 100644
>> --- a/include/linux/sunrpc/svc.h
>> +++ b/include/linux/sunrpc/svc.h
>> @@ -222,7 +222,7 @@ static inline __be32 svc_getu32(struct kvec *iov)
>>  
>>  static inline void svc_ungetu32(struct kvec *iov)
>>  {
>> -       __be32 *vp = (__be32 *)iov->iov_base;
>> +       __be32 *vp = iov->iov_base;
>>         iov->iov_base = (void *)(vp - 1);
>>         iov->iov_len += sizeof(*vp);
>>  }
> 
> If you're going to submit a patch just in order to strip unnecessary
> casts, then why are you leaving the equally unnecessary cast in the
> next line?
> 
> That said, why waste time "fixing" an inlined function that is not
> actually called anywhere in the kernel? svc_ungetu32() should just be
> removed.

Sorry for the delay, I was expecting an electrical service outage
here at home yesterday, so the lab was powered off.

So, Li, can you drop this one, and instead send a patch that removes
the definition of svc_ungetu32 ?


--
Chuck Lever