linux-kernel - Re: [PATCH] clk: qcom: gdsc: Remove direct runtime PM calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2PAXX2oYL6iFTlB@hovoldconsulting.com>
Date:   Thu, 3 Nov 2022 14:21:33 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>, linux-kernel@...r.kernel.org,
        linux-clk@...r.kernel.org, patches@...ts.linux.dev,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        linux-arm-msm@...r.kernel.org,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Johan Hovold <johan+linaro@...nel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Taniya Das <quic_tdas@...cinc.com>,
        Satya Priya <quic_c_skakit@...cinc.com>,
        Douglas Anderson <dianders@...omium.org>,
        Matthias Kaehlcke <mka@...omium.org>
Subject: Re: [PATCH] clk: qcom: gdsc: Remove direct runtime PM calls

On Wed, Nov 02, 2022 at 09:53:49AM -0700, Stephen Boyd wrote:
> Quoting Johan Hovold (2022-11-02 03:52:39)

> > > Cc: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> > > Cc: Johan Hovold <johan+linaro@...nel.org>
> > > Cc: Ulf Hansson <ulf.hansson@...aro.org>
> > > Cc: Taniya Das <quic_tdas@...cinc.com>
> > > Cc: Satya Priya <quic_c_skakit@...cinc.com>
> > > Cc: Douglas Anderson <dianders@...omium.org>
> > > Cc: Matthias Kaehlcke <mka@...omium.org>
> > > Reported-by: Stephen Boyd <swboyd@...omium.org>
> >
> > We typically don't add Reported-by tags for bugs we find and fix
> > ourselves.
> 
> Heh, I didn't see anything like that in Documentation/ so it seems fine.
> I debugged my problem and reported it.

I'd say the documentation is pretty clear on this matter:

  Reported-by: names a user who reported a problem which is fixed by this
  patch; this tag is used to give credit to the (often underappreciated)
  people who test our code and let us know when things do not work
  correctly.

  - Documentation/process/5.Posting.rst

  The Reported-by tag gives credit to people who find bugs and report
  them and it hopefully inspires them to help us again in the future.
  Please note that if the bug was reported in private, then ask for
  permission first before using the Reported-by tag.

  - Documentation/process/submitting-patches.rst

Just like you don't add a Tested-by tag for every patch you submit, it
is implied that you found the issue you fix unless you explicitly
attribute that to a third party using Reported-by.

This is the first time I see anyone trying to use Reported-by this way,
and even if you think the documentation isn't clear enough on this, our
praxis is.

Johan