linux-kernel - RE: [PATCH net v1] net: wwan: iosm: Remove unneeded if

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB5008E87F9635347AC0EB2B20D7389@SJ0PR11MB5008.namprd11.prod.outlook.com>
Date:   Thu, 3 Nov 2022 13:34:59 +0000
From:   "Kumar, M Chetan" <m.chetan.kumar@...el.com>
To:     "zhaoping.shu@...iatek.com" <zhaoping.shu@...iatek.com>,
        linuxwwan <linuxwwan@...el.com>,
        "loic.poulain@...aro.org" <loic.poulain@...aro.org>,
        "ryazanov.s.a@...il.com" <ryazanov.s.a@...il.com>,
        "johannes@...solutions.net" <johannes@...solutions.net>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "Liu, Haijun" <haijun.liu@...iatek.com>,
        "xiayu.zhang@...iatek.com" <xiayu.zhang@...iatek.com>,
        "lambert.wang@...iatek.com" <lambert.wang@...iatek.com>
Subject: RE: [PATCH net v1] net: wwan: iosm: Remove unneeded if_mutex lock

> -----Original Message-----
> From: zhaoping.shu@...iatek.com <zhaoping.shu@...iatek.com>
> Sent: Tuesday, November 1, 2022 11:21 AM
> To: Kumar, M Chetan <m.chetan.kumar@...el.com>; linuxwwan
> <linuxwwan@...el.com>; loic.poulain@...aro.org; ryazanov.s.a@...il.com;
> johannes@...solutions.net; davem@...emloft.net; edumazet@...gle.com;
> kuba@...nel.org; pabeni@...hat.com; matthias.bgg@...il.com
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org; linux-mediatek@...ts.infradead.org; Liu, Haijun
> <haijun.liu@...iatek.com>; xiayu.zhang@...iatek.com;
> lambert.wang@...iatek.com; zhaoping.shu
> <zhaoping.shu@...iatek.com>
> Subject: [PATCH net v1] net: wwan: iosm: Remove unneeded if_mutex lock
> 
> From: "zhaoping.shu" <zhaoping.shu@...iatek.com>
> 
> These WWAN network interface operations (create/delete/open/close) are
> already protected by RTNL lock, i.e., wwan_ops.newlink(),
> wwan_ops.dellink(), net_device_ops.ndo_open() and net_device.ndo_stop()
> are called with RTNL lock held.
> Therefore, this patch removes the unnecessary if_mutex.
> 
> Signed-off-by: zhaoping.shu <zhaoping.shu@...iatek.com>

Reviewed-by: M Chetan Kumar <m.chetan.kumar@...el.com>