[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y2VLddPpfjJd/yN2@smile.fi.intel.com>
Date: Fri, 4 Nov 2022 19:27:17 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
Cc: devicetree@...r.kernel.org, linux-i2c@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
Hans Verkuil <hverkuil-cisco@...all.nl>,
Jacopo Mondi <jacopo@...ndi.org>,
Kieran Bingham <kieran.bingham@...asonboard.com>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Luca Ceresoli <luca@...aceresoli.net>,
Mark Rutland <mark.rutland@....com>,
Matti Vaittinen <Matti.Vaittinen@...rohmeurope.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Peter Rosin <peda@...ntia.se>,
Rob Herring <robh+dt@...nel.org>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Vladimir Zapolskiy <vz@...ia.com>,
Wolfram Sang <wsa@...-dreams.de>,
satish.nagireddy@...cruise.com
Subject: Re: [PATCH v4 2/8] i2c: add I2C Address Translator (ATR) support
On Fri, Nov 04, 2022 at 05:26:24PM +0200, Tomi Valkeinen wrote:
> On 04/11/2022 14:38, Andy Shevchenko wrote:
> > On Fri, Nov 04, 2022 at 01:59:06PM +0200, Tomi Valkeinen wrote:
> > > On 01/11/2022 16:30, Andy Shevchenko wrote:
> > > > On Tue, Nov 01, 2022 at 03:20:26PM +0200, Tomi Valkeinen wrote:
...
> > > > > + WARN(sysfs_create_link(&chan->adap.dev.kobj, &dev->kobj, "atr_device"),
> > > > > + "can't create symlink to atr device\n");
> > > > > + WARN(sysfs_create_link(&dev->kobj, &chan->adap.dev.kobj, symlink_name),
> > > > > + "can't create symlink for channel %u\n", chan_id);
> > > >
> > > > Why WARNs? sysfs has already some in their implementation.
> > >
> > > True, and I can drop these if required. But afaics, sysfs_create_link only
> > > warns if there's a duplicate entry, not for other errors.
> >
> > The problem with WARN that it can be easily converted to real Oops. Do you
> > consider other errors are so fatal that machine would need a reboot?
>
> Yes, WARNs are bad, especially as the error here is not critical. I'll
> change these to dev_warn(). (also, I didn't know WARN could be made to
> oops).
panic_on_warn
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists