linux-kernel - Coverity: txgbe_calc_eeprom_checksum(): Control flow issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 4 Nov 2022 12:25:40 -0700
From:   coverity-bot <keescook@...omium.org>
To:     Jiawen Wu <jiawenwu@...stnetic.com>
Cc:     Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Mengyuan Lou <mengyuanlou@...-swift.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        linux-next@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Coverity: txgbe_calc_eeprom_checksum(): Control flow issues

Hello!

This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20221104 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:

  Wed Nov 2 12:31:23 2022 +0000
    049fe5365324 ("net: txgbe: Add operations to interact with firmware")

Coverity reported the following:

*** CID 1527152:  Control flow issues  (NO_EFFECT)
drivers/net/ethernet/wangxun/txgbe/txgbe_hw.c:200 in txgbe_calc_eeprom_checksum()
194
195     	for (i = 0; i < TXGBE_EEPROM_LAST_WORD; i++)
196     		if (i != wxhw->eeprom.sw_region_offset + TXGBE_EEPROM_CHECKSUM)
197     			*checksum += local_buffer[i];
198
199     	*checksum = TXGBE_EEPROM_SUM - *checksum;
vvv     CID 1527152:  Control flow issues  (NO_EFFECT)
vvv     This less-than-zero comparison of an unsigned value is never true. "*checksum < 0".
200     	if (*checksum < 0)
201     		return -EINVAL;
202
203     	if (eeprom_ptrs)
204     		kvfree(eeprom_ptrs);
205

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <keescook+coverity-bot@...omium.org>
Addresses-Coverity-ID: 1527152 ("Control flow issues")
Fixes: 049fe5365324 ("net: txgbe: Add operations to interact with firmware")

Thanks for your attention!

-- 
Coverity-bot