lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 4 Nov 2022 20:16:13 +0000 From: Dionna Glaze <dionnaglaze@...gle.com> To: linux-kernel@...r.kernel.org, x86@...nel.org Cc: Peter Gonda <pgonda@...gle.com>, Thomas Lendacky <Thomas.Lendacky@....com>, Paolo Bonzini <pbonzini@...hat.com>, Joerg Roedel <jroedel@...e.de>, Ingo Molnar <mingo@...hat.com>, Andy Lutomirsky <luto@...nel.org>, John Allen <john.allen@....com>, Herbert Xu <herbert@...dor.apana.org.au>, "David S. Miller" <davem@...emloft.net>, Dionna Glaze <dionnaglaze@...gle.com> Subject: [PATCH v7 1/4] crypto: ccp - Name -1 return value as SEV_RET_NO_FW_CALL From: Peter Gonda <pgonda@...gle.com> The PSP can return a "firmware error" code of -1 in circumstances where the PSP is not actually called. To make this protocol unambiguous, we add a constant naming the return value. Cc: Thomas Lendacky <Thomas.Lendacky@....com> Cc: Paolo Bonzini <pbonzini@...hat.com> Cc: Joerg Roedel <jroedel@...e.de> Cc: Ingo Molnar <mingo@...hat.com> Cc: Andy Lutomirsky <luto@...nel.org> Cc: John Allen <john.allen@....com> Cc: Herbert Xu <herbert@...dor.apana.org.au> Cc: "David S. Miller" <davem@...emloft.net> Signed-off-by: Peter Gonda <pgonda@...gle.com> Signed-off-by: Dionna Glaze <dionnaglaze@...gle.com> --- drivers/crypto/ccp/sev-dev.c | 2 +- include/uapi/linux/psp-sev.h | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c index 06fc7156c04f..97eb3544ab36 100644 --- a/drivers/crypto/ccp/sev-dev.c +++ b/drivers/crypto/ccp/sev-dev.c @@ -444,7 +444,7 @@ static int __sev_platform_init_locked(int *error) { struct psp_device *psp = psp_master; struct sev_device *sev; - int rc = 0, psp_ret = -1; + int rc = 0, psp_ret = SEV_RET_NO_FW_CALL; int (*init_function)(int *error); if (!psp || !psp->sev_data) diff --git a/include/uapi/linux/psp-sev.h b/include/uapi/linux/psp-sev.h index 91b4c63d5cbf..1ad7f0a7e328 100644 --- a/include/uapi/linux/psp-sev.h +++ b/include/uapi/linux/psp-sev.h @@ -36,6 +36,13 @@ enum { * SEV Firmware status code */ typedef enum { + /* + * This error code is not in the SEV spec but is added to convey that + * there was an error that prevented the SEV Firmware from being called. + * This is (u32)-1 since the firmware error code is represented as a + * 32-bit integer. + */ + SEV_RET_NO_FW_CALL = 0xffffffff, SEV_RET_SUCCESS = 0, SEV_RET_INVALID_PLATFORM_STATE, SEV_RET_INVALID_GUEST_STATE, -- 2.38.1.431.g37b22c650d-goog
Powered by blists - more mailing lists