linux-kernel - Re: [PATCH RESEND v2 11/13] dt-bindings: phy: qcom,qmp-usb: fix sc8280xp binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <166759803901.2878139.5371601797957864706.robh@kernel.org>
Date:   Fri, 4 Nov 2022 16:40:39 -0500
From:   Rob Herring <robh@...nel.org>
To:     Johan Hovold <johan+linaro@...nel.org>
Cc:     devicetree@...r.kernel.org, Bjorn Andersson <andersson@...nel.org>,
        linux-arm-msm@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        linux-phy@...ts.infradead.org, Andy Gross <agross@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Vinod Koul <vkoul@...nel.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND v2 11/13] dt-bindings: phy: qcom,qmp-usb: fix
 sc8280xp binding


On Fri, 28 Oct 2022 18:04:33 +0200, Johan Hovold wrote:
> The current QMP USB PHY bindings are based on the original MSM8996 PCIe
> PHY binding which provided multiple PHYs per IP block and these in turn
> were described by child nodes.
> 
> The QMP USB PHY block only provide a single PHY and the remnant child
> node does not really reflect the hardware.
> 
> The original MSM8996 binding also ended up describing the individual
> register blocks as belonging to either the wrapper node or the PHY child
> nodes.
> 
> This is an unnecessary level of detail which has lead to problems when
> later IP blocks using different register layouts have been forced to fit
> the original mould rather than updating the binding. The bindings are
> arguable also incomplete as they only the describe register blocks used
> by the current Linux drivers (e.g. does not include the per lane PCS
> registers).
> 
> Note that PCS_USB region is also not described by the current bindings
> despite being used by the driver and this has led to people increasing
> the size of the PCS region in the devicetree so that it includes PCS_USB
> registers even though other regions like TX and RX may lie in between.
> 
> Add a new binding for the QMP USB PHYs found on SC8280XP which further
> bindings can be based on.
> 
> Note that this also fixes the SC8280XP "phy_phy" reset name.
> 
> Also note that the current binding is simply removed instead of being
> deprecated as it was only recently merged and support for SC8280XP is
> still under development. And, specifically, there is no support in
> mainline for the multiport controller that uses these PHYs.
> 
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> ---
>  .../phy/qcom,msm8996-qmp-usb3-phy.yaml        |  13 ---
>  .../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml   | 105 ++++++++++++++++++
>  2 files changed, 105 insertions(+), 13 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
> 

Reviewed-by: Rob Herring <robh@...nel.org>