[an error occurred while processing this directive]
[an error occurred while processing this directive]
|
|
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20221104234622.2444747-1-linux@roeck-us.net>
Date: Fri, 4 Nov 2022 16:46:22 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: linux-hwmon@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, Guenter Roeck <linux@...ck-us.net>,
Marcello Sylvester Bauer <sylv@...v.io>,
Zev Weiss <zev@...ilderbeest.net>
Subject: [PATCH] Revert "hwmon: (pmbus) Add regulator supply into macro"
This reverts commit 54cc3dbfc10dc3db7cb1cf49aee4477a8398fbde.
Zev Weiss reports that the reverted patch may cause a regulator
undercount. Here is his report:
... having regulator-dummy set as a supply on my PMBus regulators
(instead of having them as their own top-level regulators without
an upstream supply) leads to enable-count underflow errors when
disabling them:
# echo 0 > /sys/bus/platform/devices/efuse01/state
[ 906.094477] regulator-dummy: Underflow of regulator enable count
[ 906.100563] Failed to disable vout: -EINVAL
[ 136.992676] reg-userspace-consumer efuse01: Failed to configure state: -22
Zev reports that reverting the patch fixes the problem. So let's do that
for now.
Fixes: 54cc3dbfc10d ("hwmon: (pmbus) Add regulator supply into macro")
Cc: Marcello Sylvester Bauer <sylv@...v.io>
Reported-by: Zev Weiss <zev@...ilderbeest.net>
Signed-off-by: Guenter Roeck <linux@...ck-us.net>
---
drivers/hwmon/pmbus/pmbus.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/hwmon/pmbus/pmbus.h b/drivers/hwmon/pmbus/pmbus.h
index 7daaf0caf4d3..10fb17879f8e 100644
--- a/drivers/hwmon/pmbus/pmbus.h
+++ b/drivers/hwmon/pmbus/pmbus.h
@@ -467,7 +467,6 @@ extern const struct regulator_ops pmbus_regulator_ops;
#define PMBUS_REGULATOR_STEP(_name, _id, _voltages, _step) \
[_id] = { \
.name = (_name # _id), \
- .supply_name = "vin", \
.id = (_id), \
.of_match = of_match_ptr(_name # _id), \
.regulators_node = of_match_ptr("regulators"), \
--
2.36.2
Powered by blists - more mailing lists