linux-kernel - Re: [PATCH V2 5/5] OPP: decouple dt properties in opp_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 04 Nov 2022 15:25:43 +1000
From:   James Calligeros <jcalligeros99@...il.com>
To:     James Calligeros <jcalligeros99@...il.com>,
        Viresh Kumar <viresh.kumar@...aro.org>
Cc:     linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org, nm@...com,
        rafael@...nel.org, sboyd@...nel.org, vincent.guittot@...aro.org,
        vireshk@...nel.org
Subject: Re: [PATCH V2 5/5] OPP: decouple dt properties in opp_parse_supplies()

On Friday, 4 November 2022 3:07:52 PM AEST Viresh Kumar wrote:
> It should happen sequentially.

 I noticed the mutexes after I got some sleep :)

> Initialize "ret = 0" in opp_parse_supplies().
> 
> Or pick patches from:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git opp/linux-next
> 

It didn't even cross my mind that opp_parse_supplies() returning
ret uninitialised was causing the failure further up the chain. Applied
and tested, everything's working as expected now. 

> Sorry for the trouble.

This is on me, I should have heeded the compiler warning.

- James