linux-kernel - Re: [PATCH -next] crypto: Remove surplus dev_err() when using platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 4 Nov 2022 08:30:42 +0100
From:   Corentin LABBE <clabbe@...libre.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     herbert@...dor.apana.org.au, davem@...emloft.net, heiko@...ech.de,
        linux-crypto@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] crypto: Remove surplus dev_err() when using
 platform_get_irq()

Le Tue, Nov 01, 2022 at 10:17:51AM +0800, Yang Li a écrit :
> There is no need to call the dev_err() function directly to print a
> custom message when handling an error from either the platform_get_irq()
> or platform_get_irq_byname() functions as both are going to display an
> appropriate error message in case of a failure.
> 
> ./drivers/crypto/rockchip/rk3288_crypto.c:351:2-9: line 351 is
> redundant because platform_get_irq() already prints an error
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2677
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---

Hello

The subject should start by "crypto: rockchip:"

Otherwise it is:
Acked-by: Corentin Labbe <clabbe@...libre.com>

Thanks