| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <ef9afdff00d9ebe0cafb4e0501b7829c715f1fc6.camel@mediatek.com>
Date: Fri, 4 Nov 2022 01:29:43 +0000
From: Chunfeng Yun (云春峰)
<Chunfeng.Yun@...iatek.com>
To: "vkoul@...nel.org" <vkoul@...nel.org>,
"lkp@...el.com" <lkp@...el.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-mediatek@...ts.infradead.org"
<linux-mediatek@...ts.infradead.org>,
"kishon@...com" <kishon@...com>,
Eddie Hung (洪正鑫)
<Eddie.Hung@...iatek.com>,
"oe-kbuild-all@...ts.linux.dev" <oe-kbuild-all@...ts.linux.dev>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
"linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
"llvm@...ts.linux.dev" <llvm@...ts.linux.dev>,
"angelogioacchino.delregno@...labora.com"
<angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH RESEND v3 2/2] phy: mediatek: tphy: add debugfs files
On Sat, 2022-10-29 at 08:46 +0800, kernel test robot wrote:
> Hi Chunfeng,
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on linus/master]
> [also build test WARNING on v6.1-rc2 next-20221028]
> [If your patch is applied to the wrong git tree, kindly drop us a
> note.
> And when submitting patch, we suggest to use '--base' as documented
> in
>
https://urldefense.com/v3/__https://git-scm.com/docs/git-format-patch*_base_tree_information__;Iw!!CTRNKA9wMg0ARbw!z3s2-V0HQmy7WniZmIk27fAkjJ-SWgBBh_9yIedH9eC1yz0opmDxTk9SKAYSolmkDxbL$
> ]
>
> url:
> https://urldefense.com/v3/__https://github.com/intel-lab-lkp/linux/commits/Chunfeng-Yun/phy-core-add-debugfs-root/20221025-134424__;!!CTRNKA9wMg0ARbw!z3s2-V0HQmy7WniZmIk27fAkjJ-SWgBBh_9yIedH9eC1yz0opmDxTk9SKAYSog09qFwS$
>
> patch link:
> https://lore.kernel.org/r/20221025054233.9763-2-chunfeng.yun%40mediatek.com
> patch subject: [PATCH RESEND v3 2/2] phy: mediatek: tphy: add debugfs
> files
> config: powerpc-allyesconfig
> compiler: clang version 16.0.0 (
> https://urldefense.com/v3/__https://github.com/llvm/llvm-project__;!!CTRNKA9wMg0ARbw!z3s2-V0HQmy7WniZmIk27fAkjJ-SWgBBh_9yIedH9eC1yz0opmDxTk9SKAYSoj8X7Pu_$
> $ 791a7ae1ba3efd6bca96338e10ffde557ba83920)
> reproduce (this is a W=1 build):
> wget
> https://urldefense.com/v3/__https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross__;!!CTRNKA9wMg0ARbw!z3s2-V0HQmy7WniZmIk27fAkjJ-SWgBBh_9yIedH9eC1yz0opmDxTk9SKAYSont3c9j-$
> -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install powerpc cross compiling tool for clang build
> # apt-get install binutils-powerpc-linux-gnu
> #
> https://urldefense.com/v3/__https://github.com/intel-lab-lkp/linux/commit/6dae09cf2d77be80664d0ec84f631c6282fdb728__;!!CTRNKA9wMg0ARbw!z3s2-V0HQmy7WniZmIk27fAkjJ-SWgBBh_9yIedH9eC1yz0opmDxTk9SKAYSoou8Is0N$
>
> git remote add linux-review
> https://urldefense.com/v3/__https://github.com/intel-lab-lkp/linux__;!!CTRNKA9wMg0ARbw!z3s2-V0HQmy7WniZmIk27fAkjJ-SWgBBh_9yIedH9eC1yz0opmDxTk9SKAYSovcqtevR$
>
> git fetch --no-tags linux-review Chunfeng-Yun/phy-core-add-
> debugfs-root/20221025-134424
> git checkout 6dae09cf2d77be80664d0ec84f631c6282fdb728
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross
> W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/phy/mediatek/
> drivers/staging/rtl8723bs/ drivers/tty/serial/
>
> If you fix the issue, kindly add following tag where applicable
> > Reported-by: kernel test robot <lkp@...el.com>
>
> All warnings (new ones prefixed by >>):
>
> BUILD_BUG_ON_MSG(__bf_cast_unsigned(_mask, _mask)
> > \
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ^~~~~~~
> note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-
> limit=0 to see all)
> include/linux/compiler_types.h:357:22: note: expanded from macro
> 'compiletime_assert'
> _compiletime_assert(condition, msg, __compiletime_assert_,
> __COUNTER__)
> ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~~~~~~~~~~~~~
> include/linux/compiler_types.h:345:23: note: expanded from macro
> '_compiletime_assert'
> __compiletime_assert(condition, msg, prefix, suffix)
> ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/compiler_types.h:337:9: note: expanded from macro
> '__compiletime_assert'
> if
> (!(condition)) \
> ^~~~~~~~~
> drivers/phy/mediatek/phy-mtk-tphy.c:479:4: warning: result of
> comparison of constant 18446744073709551615 with expression of type
> 'typeof (_Generic((mask_), char: (unsigned char)0, unsigned char:
> (unsigned char)0, signed char: (unsigned char)0, unsigned short:
> (unsigned short)0, short: (unsigned short)0, unsigned int: (unsigned
> int)0, int: (unsigned int)0, unsigned long: (unsigned long)0, long:
> (unsigned long)0, unsigned long long: (unsigned long long)0, long
> long: (unsigned long long)0, default: (mask_)))' (aka 'unsigned
> long') is always false [-Wtautological-constant-out-of-range-compare]
> mtk_phy_update_field(u2_banks->misc +
> U3P_MISC_REG1,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~~~~~~~~~~
> drivers/phy/mediatek/phy-mtk-io.h:43:34: note: expanded from macro
> 'mtk_phy_update_field'
> mtk_phy_update_bits(reg, mask_, FIELD_PREP(mask_, val)); \
> ^~~~~~~~~~~~~~~~~~~~~~
> include/linux/bitfield.h:114:3: note: expanded from macro
> 'FIELD_PREP'
> __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP:
> "); \
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~
> include/linux/bitfield.h:71:53: note: expanded from macro
> '__BF_FIELD_CHECK'
> BUILD_BUG_ON_MSG(__bf_cast_unsigned(_mask, _mask)
> > \
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ^~~~~~~
> note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-
> limit=0 to see all)
> include/linux/compiler_types.h:357:22: note: expanded from macro
> 'compiletime_assert'
> _compiletime_assert(condition, msg, __compiletime_assert_,
> __COUNTER__)
> ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~~~~~~~~~~~~~
> include/linux/compiler_types.h:345:23: note: expanded from macro
> '_compiletime_assert'
> __compiletime_assert(condition, msg, prefix, suffix)
> ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/compiler_types.h:337:9: note: expanded from macro
> '__compiletime_assert'
> if
> (!(condition)) \
> ^~~~~~~~~
> drivers/phy/mediatek/phy-mtk-tphy.c:484:3: warning: result of
> comparison of constant 18446744073709551615 with expression of type
> 'typeof (_Generic((mask_), char: (unsigned char)0, unsigned char:
> (unsigned char)0, signed char: (unsigned char)0, unsigned short:
> (unsigned short)0, short: (unsigned short)0, unsigned int: (unsigned
> int)0, int: (unsigned int)0, unsigned long: (unsigned long)0, long:
> (unsigned long)0, unsigned long long: (unsigned long long)0, long
> long: (unsigned long long)0, default: (mask_)))' (aka 'unsigned
> long') is always false [-Wtautological-constant-out-of-range-compare]
> mtk_phy_update_field(com + U3P_USBPHYACR1,
> PA1_RG_INTR_CAL, val);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~~~~~~~~~~~~~~
> drivers/phy/mediatek/phy-mtk-io.h:43:34: note: expanded from macro
> 'mtk_phy_update_field'
> mtk_phy_update_bits(reg, mask_, FIELD_PREP(mask_, val)); \
> ^~~~~~~~~~~~~~~~~~~~~~
> include/linux/bitfield.h:114:3: note: expanded from macro
> 'FIELD_PREP'
> __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP:
> "); \
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~
> include/linux/bitfield.h:71:53: note: expanded from macro
> '__BF_FIELD_CHECK'
> BUILD_BUG_ON_MSG(__bf_cast_unsigned(_mask, _mask)
> > \
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ^~~~~~~
> note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-
> limit=0 to see all)
> include/linux/compiler_types.h:357:22: note: expanded from macro
> 'compiletime_assert'
> _compiletime_assert(condition, msg, __compiletime_assert_,
> __COUNTER__)
> ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~~~~~~~~~~~~~
> include/linux/compiler_types.h:345:23: note: expanded from macro
> '_compiletime_assert'
> __compiletime_assert(condition, msg, prefix, suffix)
> ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/compiler_types.h:337:9: note: expanded from macro
> '__compiletime_assert'
> if
> (!(condition)) \
> ^~~~~~~~~
> drivers/phy/mediatek/phy-mtk-tphy.c:488:3: warning: result of
> comparison of constant 18446744073709551615 with expression of type
> 'typeof (_Generic((mask_), char: (unsigned char)0, unsigned char:
> (unsigned char)0, signed char: (unsigned char)0, unsigned short:
> (unsigned short)0, short: (unsigned short)0, unsigned int: (unsigned
> int)0, int: (unsigned int)0, unsigned long: (unsigned long)0, long:
> (unsigned long)0, unsigned long long: (unsigned long long)0, long
> long: (unsigned long long)0, default: (mask_)))' (aka 'unsigned
> long') is always false [-Wtautological-constant-out-of-range-compare]
> mtk_phy_update_field(com + U3P_USBPHYACR6,
> PA6_RG_U2_DISCTH, val);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~~~~~~~~~~~~~~~
> drivers/phy/mediatek/phy-mtk-io.h:43:34: note: expanded from macro
> 'mtk_phy_update_field'
> mtk_phy_update_bits(reg, mask_, FIELD_PREP(mask_, val)); \
> ^~~~~~~~~~~~~~~~~~~~~~
> include/linux/bitfield.h:114:3: note: expanded from macro
> 'FIELD_PREP'
> __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP:
> "); \
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~
> include/linux/bitfield.h:71:53: note: expanded from macro
> '__BF_FIELD_CHECK'
> BUILD_BUG_ON_MSG(__bf_cast_unsigned(_mask, _mask)
> > \
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ^~~~~~~
> note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-
> limit=0 to see all)
> include/linux/compiler_types.h:357:22: note: expanded from macro
> 'compiletime_assert'
> _compiletime_assert(condition, msg, __compiletime_assert_,
> __COUNTER__)
> ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~~~~~~~~~~~~~
> include/linux/compiler_types.h:345:23: note: expanded from macro
> '_compiletime_assert'
> __compiletime_assert(condition, msg, prefix, suffix)
> ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/compiler_types.h:337:9: note: expanded from macro
> '__compiletime_assert'
> if
> (!(condition)) \
> ^~~~~~~~~
> drivers/phy/mediatek/phy-mtk-tphy.c:492:3: warning: result of
> comparison of constant 18446744073709551615 with expression of type
> 'typeof (_Generic((mask_), char: (unsigned char)0, unsigned char:
> (unsigned char)0, signed char: (unsigned char)0, unsigned short:
> (unsigned short)0, short: (unsigned short)0, unsigned int: (unsigned
> int)0, int: (unsigned int)0, unsigned long: (unsigned long)0, long:
> (unsigned long)0, unsigned long long: (unsigned long long)0, long
> long: (unsigned long long)0, default: (mask_)))' (aka 'unsigned
> long') is always false [-Wtautological-constant-out-of-range-compare]
> mtk_phy_update_field(com + U3P_USBPHYACR6,
> PA6_RG_U2_PRE_EMP, val);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~~~~~~~~~~~~~~~~
> drivers/phy/mediatek/phy-mtk-io.h:43:34: note: expanded from macro
> 'mtk_phy_update_field'
> mtk_phy_update_bits(reg, mask_, FIELD_PREP(mask_, val)); \
> ^~~~~~~~~~~~~~~~~~~~~~
> include/linux/bitfield.h:114:3: note: expanded from macro
> 'FIELD_PREP'
> __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP:
> "); \
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~
> include/linux/bitfield.h:71:53: note: expanded from macro
> '__BF_FIELD_CHECK'
> BUILD_BUG_ON_MSG(__bf_cast_unsigned(_mask, _mask)
> > \
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ^~~~~~~
> note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-
> limit=0 to see all)
> include/linux/compiler_types.h:357:22: note: expanded from macro
> 'compiletime_assert'
> _compiletime_assert(condition, msg, __compiletime_assert_,
> __COUNTER__)
> ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~~~~~~~~~~~~~
> include/linux/compiler_types.h:345:23: note: expanded from macro
> '_compiletime_assert'
> __compiletime_assert(condition, msg, prefix, suffix)
> ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/compiler_types.h:337:9: note: expanded from macro
> '__compiletime_assert'
> if
> (!(condition)) \
> ^~~~~~~~~
> > > drivers/phy/mediatek/phy-mtk-tphy.c:556:2: warning: variable
> > > 'val' is used uninitialized whenever switch default is taken [-
> > > Wsometimes-uninitialized]
>
> default:
> ^~~~~~~
> drivers/phy/mediatek/phy-mtk-tphy.c:561:45: note: uninitialized
> use occurs here
> seq_printf(sf, "%s : %d [0, %d]\n", fname, val, max);
> ^~~
> drivers/phy/mediatek/phy-mtk-tphy.c:524:9: note: initialize the
> variable 'val' to silence this warning
> u32 val, tmp, max;
> ^
> = 0
> > > drivers/phy/mediatek/phy-mtk-tphy.c:556:2: warning: variable
> > > 'max' is used uninitialized whenever switch default is taken [-
> > > Wsometimes-uninitialized]
>
> default:
> ^~~~~~~
> drivers/phy/mediatek/phy-mtk-tphy.c:561:50: note: uninitialized
> use occurs here
> seq_printf(sf, "%s : %d [0, %d]\n", fname, val, max);
> ^~~
> drivers/phy/mediatek/phy-mtk-tphy.c:524:19: note: initialize the
> variable 'max' to silence this warning
> u32 val, tmp, max;
> ^
> = 0
> drivers/phy/mediatek/phy-mtk-tphy.c:593:3: warning: result of
> comparison of constant 18446744073709551615 with expression of type
> 'typeof (_Generic((mask_), char: (unsigned char)0, unsigned char:
> (unsigned char)0, signed char: (unsigned char)0, unsigned short:
> (unsigned short)0, short: (unsigned short)0, unsigned int: (unsigned
> int)0, int: (unsigned int)0, unsigned long: (unsigned long)0, long:
> (unsigned long)0, unsigned long long: (unsigned long long)0, long
> long: (unsigned long long)0, default: (mask_)))' (aka 'unsigned
> long') is always false [-Wtautological-constant-out-of-range-compare]
> mtk_phy_update_field(phyd + U3P_U3_PHYD_RSV,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/phy/mediatek/phy-mtk-io.h:43:34: note: expanded from macro
> 'mtk_phy_update_field'
> mtk_phy_update_bits(reg, mask_, FIELD_PREP(mask_, val)); \
> ^~~~~~~~~~~~~~~~~~~~~~
> include/linux/bitfield.h:114:3: note: expanded from macro
> 'FIELD_PREP'
> __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP:
> "); \
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~
> include/linux/bitfield.h:71:53: note: expanded from macro
> '__BF_FIELD_CHECK'
> BUILD_BUG_ON_MSG(__bf_cast_unsigned(_mask, _mask)
> > \
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ^~~~~~~
> note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-
> limit=0 to see all)
> include/linux/compiler_types.h:357:22: note: expanded from macro
> 'compiletime_assert'
> _compiletime_assert(condition, msg, __compiletime_assert_,
> __COUNTER__)
> ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~~~~~~~~~~~~~
> include/linux/compiler_types.h:345:23: note: expanded from macro
> '_compiletime_assert'
> __compiletime_assert(condition, msg, prefix, suffix)
> ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/compiler_types.h:337:9: note: expanded from macro
> '__compiletime_assert'
> if
> (!(condition)) \
> ^~~~~~~~~
> drivers/phy/mediatek/phy-mtk-tphy.c:598:3: warning: result of
> comparison of constant 18446744073709551615 with expression of type
> 'typeof (_Generic((mask_), char: (unsigned char)0, unsigned char:
> (unsigned char)0, signed char: (unsigned char)0, unsigned short:
> (unsigned short)0, short: (unsigned short)0, unsigned int: (unsigned
> int)0, int: (unsigned int)0, unsigned long: (unsigned long)0, long:
> (unsigned long)0, unsigned long long: (unsigned long long)0, long
> long: (unsigned long long)0, default: (mask_)))' (aka 'unsigned
> long') is always false [-Wtautological-constant-out-of-range-compare]
> mtk_phy_update_field(u3_banks->phya +
> U3P_U3_PHYA_REG0, P3A_RG_IEXT_INTR, val);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/phy/mediatek/phy-mtk-io.h:43:34: note: expanded from macro
> 'mtk_phy_update_field'
> mtk_phy_update_bits(reg, mask_, FIELD_PREP(mask_, val)); \
> ^~~~~~~~~~~~~~~~~~~~~~
> include/linux/bitfield.h:114:3: note: expanded from macro
> 'FIELD_PREP'
> __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP:
> "); \
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~
> include/linux/bitfield.h:71:53: note: expanded from macro
> '__BF_FIELD_CHECK'
> BUILD_BUG_ON_MSG(__bf_cast_unsigned(_mask, _mask)
> > \
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ^~~~~~~
> note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-
> limit=0 to see all)
> include/linux/compiler_types.h:357:22: note: expanded from macro
> 'compiletime_assert'
> _compiletime_assert(condition, msg, __compiletime_assert_,
> __COUNTER__)
> ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~~~~~~~~~~~~~
> include/linux/compiler_types.h:345:23: note: expanded from macro
> '_compiletime_assert'
> __compiletime_assert(condition, msg, prefix, suffix)
> ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/compiler_types.h:337:9: note: expanded from macro
> '__compiletime_assert'
> if
> (!(condition)) \
> ^~~~~~~~~
> drivers/phy/mediatek/phy-mtk-tphy.c:602:3: warning: result of
> comparison of constant 18446744073709551615 with expression of type
> 'typeof (_Generic((mask_), char: (unsigned char)0, unsigned char:
> (unsigned char)0, signed char: (unsigned char)0, unsigned short:
> (unsigned short)0, short: (unsigned short)0, unsigned int: (unsigned
> int)0, int: (unsigned int)0, unsigned long: (unsigned long)0, long:
> (unsigned long)0, unsigned long long: (unsigned long long)0, long
> long: (unsigned long long)0, default: (mask_)))' (aka 'unsigned
> long') is always false [-Wtautological-constant-out-of-range-compare]
> mtk_phy_update_field(phyd + U3P_U3_PHYD_IMPCAL0,
> P3D_RG_TX_IMPEL, val);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~~~~~~~~~~~~~~~~~~~~
> drivers/phy/mediatek/phy-mtk-io.h:43:34: note: expanded from macro
> 'mtk_phy_update_field'
> mtk_phy_update_bits(reg, mask_, FIELD_PREP(mask_, val)); \
> ^~~~~~~~~~~~~~~~~~~~~~
> include/linux/bitfield.h:114:3: note: expanded from macro
> 'FIELD_PREP'
> __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP:
> "); \
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~
> include/linux/bitfield.h:71:53: note: expanded from macro
> '__BF_FIELD_CHECK'
> BUILD_BUG_ON_MSG(__bf_cast_unsigned(_mask, _mask)
> > \
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ^~~~~~~
> note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-
> limit=0 to see all)
> include/linux/compiler_types.h:357:22: note: expanded from macro
> 'compiletime_assert'
> _compiletime_assert(condition, msg, __compiletime_assert_,
> __COUNTER__)
> ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~~~~~~~~~~~~~
> include/linux/compiler_types.h:345:23: note: expanded from macro
> '_compiletime_assert'
> __compiletime_assert(condition, msg, prefix, suffix)
> ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/compiler_types.h:337:9: note: expanded from macro
> '__compiletime_assert'
> if
> (!(condition)) \
> ^~~~~~~~~
> drivers/phy/mediatek/phy-mtk-tphy.c:607:3: warning: result of
> comparison of constant 18446744073709551615 with expression of type
> 'typeof (_Generic((mask_), char: (unsigned char)0, unsigned char:
> (unsigned char)0, signed char: (unsigned char)0, unsigned short:
> (unsigned short)0, short: (unsigned short)0, unsigned int: (unsigned
> int)0, int: (unsigned int)0, unsigned long: (unsigned long)0, long:
> (unsigned long)0, unsigned long long: (unsigned long long)0, long
> long: (unsigned long long)0, default: (mask_)))' (aka 'unsigned
> long') is always false [-Wtautological-constant-out-of-range-compare]
> mtk_phy_update_field(phyd + U3P_U3_PHYD_IMPCAL1,
> P3D_RG_RX_IMPEL, val);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~~~~~~~~~~~~~~~~~~~~
> drivers/phy/mediatek/phy-mtk-io.h:43:34: note: expanded from macro
> 'mtk_phy_update_field'
> mtk_phy_update_bits(reg, mask_, FIELD_PREP(mask_, val)); \
> ^~~~~~~~~~~~~~~~~~~~~~
> include/linux/bitfield.h:114:3: note: expanded from macro
> 'FIELD_PREP'
> __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP:
> "); \
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~
> include/linux/bitfield.h:71:53: note: expanded from macro
> '__BF_FIELD_CHECK'
> BUILD_BUG_ON_MSG(__bf_cast_unsigned(_mask, _mask)
> > \
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ^~~~~~~
> note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-
> limit=0 to see all)
> include/linux/compiler_types.h:357:22: note: expanded from macro
> 'compiletime_assert'
> _compiletime_assert(condition, msg, __compiletime_assert_,
> __COUNTER__)
> ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~~~~~~~~~~~~~
> include/linux/compiler_types.h:345:23: note: expanded from macro
> '_compiletime_assert'
> __compiletime_assert(condition, msg, prefix, suffix)
> ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/compiler_types.h:337:9: note: expanded from macro
> '__compiletime_assert'
> if
> (!(condition)) \
> ^~~~~~~~~
> drivers/phy/mediatek/phy-mtk-tphy.c:785:2: warning: result of
> comparison of constant 18446744073709551615 with expression of type
> 'typeof (_Generic((mask_), char: (unsigned char)0, unsigned char:
> (unsigned char)0, signed char: (unsigned char)0, unsigned short:
> (unsigned short)0, short: (unsigned short)0, unsigned int: (unsigned
> int)0, int: (unsigned int)0, unsigned long: (unsigned long)0, long:
> (unsigned long)0, unsigned long long: (unsigned long long)0, long
> long: (unsigned long long)0, default: (mask_)))' (aka 'unsigned
> long') is always false [-Wtautological-constant-out-of-range-compare]
> mtk_phy_update_field(com + U3P_USBPHYACR5,
> PA5_RG_U2_HSTX_SRCTRL,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~~~~~~~
>
>
> vim +/val +556 drivers/phy/mediatek/phy-mtk-tphy.c
>
> 518
> 519 static int u3_phy_params_show(struct seq_file *sf, void
> *unused)
> 520 {
> 521 struct mtk_phy_instance *inst = sf->private;
> 522 const char *fname = file_dentry(sf->file)-
> >d_iname;
> 523 struct u3phy_banks *u3_banks = &inst->u3_banks;
> 524 u32 val, tmp, max;
> 525 int ret;
> 526
> 527 ret = match_string(u3_phy_files,
> ARRAY_SIZE(u3_phy_files), fname);
> 528 if (ret < 0)
> 529 return ret;
> 530
> 531 switch (ret) {
> 532 case U3P_EFUSE_EN:
> 533 tmp = readl(u3_banks->phyd +
> U3P_U3_PHYD_RSV);
> 534 val = !!(tmp &
> P3D_RG_EFUSE_AUTO_LOAD_DIS);
> 535 max = 1;
> 536 break;
> 537
> 538 case U3P_EFUSE_INTR:
> 539 tmp = readl(u3_banks->phya +
> U3P_U3_PHYA_REG0);
> 540 val = FIELD_GET(P3A_RG_IEXT_INTR, tmp);
> 541 max = FIELD_MAX(P3A_RG_IEXT_INTR);
> 542 break;
> 543
> 544 case U3P_EFUSE_TX_IMP:
> 545 tmp = readl(u3_banks->phyd +
> U3P_U3_PHYD_IMPCAL0);
> 546 val = FIELD_GET(P3D_RG_TX_IMPEL, tmp);
> 547 max = FIELD_MAX(P3D_RG_TX_IMPEL);
> 548 break;
> 549
> 550 case U3P_EFUSE_RX_IMP:
> 551 tmp = readl(u3_banks->phyd +
> U3P_U3_PHYD_IMPCAL1);
> 552 val = FIELD_GET(P3D_RG_RX_IMPEL, tmp);
> 553 max = FIELD_MAX(P3D_RG_RX_IMPEL);
> 554 break;
> 555
> > 556 default:
> 557 seq_printf(sf, "invalid, %d\n", ret);
> 558 break;
> 559 }
> 560
> 561 seq_printf(sf, "%s : %d [0, %d]\n", fname, val,
> max);
> 562
> 563 return 0;
> 564 }
> 565
>
I'll send a new version patch to fix the warnings;
Thanks
Powered by blists - more mailing lists