linux-kernel - Re: [PATCH] irqchip: loongson-liointc: fix improper error handling in liointc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <539b63ee-7655-50c1-a95f-9f8210e7229d@gmail.com>
Date:   Fri, 4 Nov 2022 12:48:40 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...il.com>
To:     Liu Peibao <liupeibao@...ngson.cn>,
        Huacai Chen <chenhuacai@...nel.org>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Marc Zyngier <maz@...nel.org>,
        Jianmin Lv <lvjianmin@...ngson.cn>
Cc:     Yinbo Zhu <zhuyinbo@...ngson.cn>, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irqchip: loongson-liointc: fix improper error handling in
 liointc_init()

Hello!

On 11/4/22 11:03 AM, Liu Peibao wrote:

> For cores less than 4, eg, loongson2k1000 with 2 cores, the
> of_property_match_string() may return with an error value,
> which causes that liointc could not work. At least one isr
> is what should be checked like previous commit <b2c4c3969fd7>
> (irqchip/loongson-liointc: irqchip add 2.0 version) did.

   It should look like this:

commit b2c4c3969fd7 ("irqchip/loongson-liointc: irqchip add 2.0 version")

> Fixes: 0858ed035a85 ("irqchip/loongson-liointc: Add ACPI init support")
> Signed-off-by: Liu Peibao <liupeibao@...ngson.cn>
[...]

MBR, Sergey