linux-kernel - Re: [PATCH v2] dt-bindings: net: nxp,sja1105: document spi-cpol/cpha

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <698c3a72-f694-01ac-80ba-13bd40bb6534@linaro.org>
Date:   Thu, 3 Nov 2022 21:44:36 -0400
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: net: nxp,sja1105: document spi-cpol/cpha

On 03/11/2022 19:33, Vladimir Oltean wrote:
> Hi Krzysztof,
> 
> On Wed, Nov 02, 2022 at 02:52:32PM -0400, Krzysztof Kozlowski wrote:
>> Some boards use SJA1105 Ethernet Switch with SPI CPOL and CPHA, so
>> document this to fix dtbs_check warnings:
>>
>>   arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3.dtb: ethernet-switch@0: Unevaluated properties are not allowed ('spi-cpol' was unexpected)
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>
>> ---
>>
>> Changes since v1:
>> 1. Add also cpha
>> ---
>>  Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml b/Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml
>> index 1e26d876d146..3debbf0f3789 100644
>> --- a/Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml
>> +++ b/Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml
>> @@ -36,6 +36,9 @@ properties:
>>    reg:
>>      maxItems: 1
>>  
>> +  spi-cpha: true
>> +  spi-cpol: true
>> +
>>    # Optional container node for the 2 internal MDIO buses of the SJA1110
>>    # (one for the internal 100base-T1 PHYs and the other for the single
>>    # 100base-TX PHY). The "reg" property does not have physical significance.
>> -- 
>> 2.34.1
>>
> 
> Don't these belong to spi-peripheral-props.yaml?

No, they are device specific, not controller specific. Every device
requiring them must explicitly include them.

See:
https://lore.kernel.org/all/20220816124321.67817-1-krzysztof.kozlowski@linaro.org/

Best regards,
Krzysztof