linux-kernel - RE: [PATCH 3/3] arm64: dts: exynos: Rename compatible string property from version to SOC specific

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <000001d8f03b$1cd111f0$567335d0$@samsung.com>
Date:   Fri, 4 Nov 2022 16:19:24 +0530
From:   "Aakarsh Jain" <aakarsh.jain@...sung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@...aro.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>
Cc:     <m.szyprowski@...sung.com>, <andrzej.hajda@...el.com>,
        <mchehab@...nel.org>, <hverkuil-cisco@...all.nl>,
        <ezequiel@...guardiasur.com.ar>, <jernej.skrabec@...il.com>,
        <benjamin.gaignard@...labora.com>,
        <krzysztof.kozlowski+dt@...aro.org>,
        <stanimir.varbanov@...aro.org>, <dillon.minfei@...il.com>,
        <david.plowman@...pberrypi.com>, <mark.rutland@....com>,
        <robh+dt@...nel.org>, <krzk+dt@...nel.org>, <andi@...zian.org>,
        <alim.akhtar@...sung.com>, <aswani.reddy@...sung.com>,
        <pankaj.dubey@...sung.com>, <smitha.t@...sung.com>
Subject: RE: [PATCH 3/3] arm64: dts: exynos: Rename compatible string
 property from version to SOC specific



> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@...aro.org]
> Sent: 03 November 2022 18:04
> To: Aakarsh Jain <aakarsh.jain@...sung.com>; linux-arm-
> kernel@...ts.infradead.org; linux-media@...r.kernel.org; linux-
> kernel@...r.kernel.org; devicetree@...r.kernel.org
> Cc: m.szyprowski@...sung.com; andrzej.hajda@...el.com;
> mchehab@...nel.org; hverkuil-cisco@...all.nl;
> ezequiel@...guardiasur.com.ar; jernej.skrabec@...il.com;
> benjamin.gaignard@...labora.com; krzysztof.kozlowski+dt@...aro.org;
> stanimir.varbanov@...aro.org; dillon.minfei@...il.com;
> david.plowman@...pberrypi.com; mark.rutland@....com;
> robh+dt@...nel.org; krzk+dt@...nel.org; andi@...zian.org;
> alim.akhtar@...sung.com; aswani.reddy@...sung.com;
> pankaj.dubey@...sung.com; smitha.t@...sung.com
> Subject: Re: [PATCH 3/3] arm64: dts: exynos: Rename compatible string
> property from version to SOC specific
> 
> On 02/11/2022 09:06, Aakarsh Jain wrote:
> > commit "752d3a23d1f68de87e3c" which adds MFC codec device node for
> > exynos3250 SOC. Since exynos3250.dtsi and exynos5420.dtsi are using
> > same compatible string as "samsung,mfc-v7" but their node properties
> > are different.As both SoCs have MFC v7 hardware module but with
> > different clock hierarchy and complexity.
> > So renaming compatible string from version specific to SOC based.
> >
> > Suggested-by: Alim Akhtar <alim.akhtar@...sung.com>
> > Fixes: 752d3a23d1f6 ("ARM: dts: add MFC codec device node for
> > exynos3250")
> 
> There is no bug to fix and backporting is forbidden as it breaks the usage of
> DTS in older kernel.
> 
Okay will remove this Fix tag in next series.
> > Signed-off-by: Aakarsh Jain <aakarsh.jain@...sung.com>
> > ---
> >  arch/arm/boot/dts/exynos3250.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos3250.dtsi
> > b/arch/arm/boot/dts/exynos3250.dtsi
> > index 326b9e0ed8d3..98105c64f7d9 100644
> > --- a/arch/arm/boot/dts/exynos3250.dtsi
> > +++ b/arch/arm/boot/dts/exynos3250.dtsi
> > @@ -485,7 +485,7 @@
> >  		};
> >
> >  		mfc: codec@...00000 {
> > -			compatible = "samsung,mfc-v7";
> > +			compatible = "samsung,exynos3250-mfc";
> 
> The change is non-bisectable and breaks using DTS in older kernel.
> 
Right, so what is your suggestion on this?
I can see two ways here:
1> To squash patch2 and patch3 in one?
2> Have a warning about this breakage in the patch-3 commit message?

> Best regards,
> Krzysztof


Thanks for the review.