linux-kernel - Re: [tip:perf/core 1/2] kernel/events/core.c:181:48: error: redefinition of 'cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y2UMzdf9EDN1z5Ym@hirez.programming.kicks-ass.net>
Date:   Fri, 4 Nov 2022 13:59:57 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     "Chen, Rong A" <rong.a.chen@...el.com>
Cc:     kernel test robot <lkp@...el.com>, llvm@...ts.linux.dev,
        oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        x86@...nel.org, Ravi Bangoria <ravi.bangoria@....com>
Subject: Re: [tip:perf/core 1/2] kernel/events/core.c:181:48: error:
 redefinition of 'cpu_context' as different kind of symbol

On Fri, Nov 04, 2022 at 02:08:48PM +0800, Chen, Rong A wrote:
> 
> 
> On 10/28/2022 1:12 AM, Peter Zijlstra wrote:
> > On Thu, Oct 27, 2022 at 10:03:53PM +0800, kernel test robot wrote:
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf/core
> > > head:   dc39beffcfc19a8dd2a09c5818dcd1a4e9099033
> > > commit: 983bd8543b5ab8e9a2870ae258bccd4ce7a22c7c [1/2] perf: Rewrite core context handling
> > > config: mips-randconfig-r024-20221026
> > > compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920)
> > > reproduce (this is a W=1 build):
> > >          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > >          chmod +x ~/bin/make.cross
> > >          # install mips cross compiling tool for clang build
> > >          # apt-get install binutils-mips64el-linux-gnuabi64
> > >          # https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=983bd8543b5ab8e9a2870ae258bccd4ce7a22c7c
> > >          git remote add tip https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
> > >          git fetch --no-tags tip perf/core
> > >          git checkout 983bd8543b5ab8e9a2870ae258bccd4ce7a22c7c
> > >          # save the config file
> > >          mkdir build_dir && cp config build_dir/.config
> > >          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash kernel/
> > > 
> > > If you fix the issue, kindly add following tag where applicable
> > > | Reported-by: kernel test robot <lkp@...el.com>
> > > 
> > > All errors (new ones prefixed by >>):
> > > 
> > > > > kernel/events/core.c:181:48: error: redefinition of 'cpu_context' as different kind of symbol
> > >     static DEFINE_PER_CPU(struct perf_cpu_context, cpu_context);
> > >                                                    ^
> > >     arch/mips/include/asm/mmu_context.h:106:19: note: previous definition is here
> > >     static inline u64 cpu_context(unsigned int cpu, const struct mm_struct *mm)
> > 
> > *sigh*.. robot people.. this patch has sat in my queue.git for weeks now
> > :/
> 
> Hi Peter,
> 
> Sorry about that, I checked the internal reports, the error was first
> found on Oct 14, but it's blocked due to commit id changed in the same
> branch, we'll enhance the check logic to avoid blocking such cases.

Ah, since I maintain my patches in quilt series and I re-generate my git
trees from that, I very frequently force-push stuff -- even when nothing
changes for a particular tree.

Basically my script wipes the entire git repository, takes a new tip
clone and applies my quilt series to appropriate branchs and pushes the
whole thing out.

So yeah, please don't let that block reports.