linux-kernel - Re: [PATCH] sunrpc: svc: Remove an unused static function svc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <A9993DD4-5A7C-42FF-9CAB-6BFD61075981@oracle.com>
Date:   Fri, 4 Nov 2022 13:44:43 +0000
From:   Chuck Lever III <chuck.lever@...cle.com>
To:     Li zeming <zeming@...china.com>
CC:     Trond Myklebust <trond.myklebust@...merspace.com>,
        Anna Schumaker <anna@...nel.org>,
        Jeff Layton <jlayton@...nel.org>,
        Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sunrpc: svc: Remove an unused static function
 svc_ungetu32()



> On Nov 3, 2022, at 9:43 PM, Li zeming <zeming@...china.com> wrote:
> 
> The svc_ungetu32 function is not used, you could remove it.
> 
> Signed-off-by: Li zeming <zeming@...china.com>

Applied to nfsd's for-next. Thanks!


> ---
> include/linux/sunrpc/svc.h | 7 -------
> 1 file changed, 7 deletions(-)
> 
> diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
> index daecb009c05b..6990867470ca 100644
> --- a/include/linux/sunrpc/svc.h
> +++ b/include/linux/sunrpc/svc.h
> @@ -220,13 +220,6 @@ static inline __be32 svc_getu32(struct kvec *iov)
> 	return val;
> }
> 
> -static inline void svc_ungetu32(struct kvec *iov)
> -{
> -	__be32 *vp = (__be32 *)iov->iov_base;
> -	iov->iov_base = (void *)(vp - 1);
> -	iov->iov_len += sizeof(*vp);
> -}
> -
> static inline void svc_putu32(struct kvec *iov, __be32 val)
> {
> 	__be32 *vp = iov->iov_base + iov->iov_len;
> -- 
> 2.18.2
> 

--
Chuck Lever