linux-kernel - Re: [PATCH] dt-bindings: clock: exynosautov9: fix reference to CMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f026f38-ef09-788e-7bd8-45683b074075@linaro.org>
Date:   Fri, 4 Nov 2022 09:55:16 -0400
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Inbaraj <inbaraj.e@...sung.com>, s.nawrocki@...sung.com,
        tomasz.figa@...il.com, cw00.choi@...sung.com,
        alim.akhtar@...sung.com, mturquette@...libre.com, sboyd@...nel.org,
        robh+dt@...nel.org, chanho61.park@...sung.com
Cc:     linux-samsung-soc@...r.kernel.org, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, pankaj.dubey@...sung.com
Subject: Re: [PATCH] dt-bindings: clock: exynosautov9: fix reference to
 CMU_FSYS1 mmc card clock

On 04/11/2022 05:00, Inbaraj wrote:
> Fix reference to CMU_FSYS1 mmc card clock to gout clock instead of dout.
> 
> This fixes make dtbs_check warning as shown below:
> 
> arch/arm64/boot/dts/exynos/exynosautov9-sadk.dtb: clock-controller@...40000:
> clock-names:2: 'dout_clkcmu_fsys1_mmc_card' was expected
> From schema: /home/inbaraj/mainline/linux/Documentation/devicetree/
> bindings/clock/samsung,exynosautov9-clock.yaml

I don't understand:
1. Why bindings are wrong not DTSI?
2. What is "gout"? "dout" had a meaning as clock divider output.

> 
> Fixes: 4b6ec8d88623 ("dt-bindings: clock: exynosautov9: add schema for cmu_fsys0/1")
> Signed-off-by: Inbaraj <inbaraj.e@...sung.com>
> ---
>  .../devicetree/bindings/clock/samsung,exynosautov9-clock.yaml   | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml b/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml
> index 2ab4642679c0..55c4f94a14d1 100644
> --- a/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml
> @@ -148,7 +148,7 @@ allOf:
>            items:
>              - const: oscclk
>              - const: dout_clkcmu_fsys1_bus
> -            - const: dout_clkcmu_fsys1_mmc_card
> +            - const: gout_clkcmu_fsys1_mmc_card
>              - const: dout_clkcmu_fsys1_usbdrd
>  
>    - if:

Best regards,
Krzysztof