linux-kernel - Re: [PATCH 1/2] dt-bindings: soc: qcom: Add bindings for Qualcomm Ramp Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4bd3afed-f0c7-8479-2e35-f56f542da674@linaro.org>
Date:   Fri, 4 Nov 2022 10:00:48 -0400
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>, agross@...nel.org
Cc:     andersson@...nel.org, konrad.dybcio@...ainline.org,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, marijn.suijten@...ainline.org,
        kernel@...labora.com
Subject: Re: [PATCH 1/2] dt-bindings: soc: qcom: Add bindings for Qualcomm
 Ramp Controller

On 04/11/2022 09:35, AngeloGioacchino Del Regno wrote:
> Document bindings for the Qualcomm Ramp Controller, found on various
> legacy Qualcomm SoCs.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> ---
>  .../soc/qcom/qcom,ramp-controller.yaml        | 42 +++++++++++++++++++
>  1 file changed, 42 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,ramp-controller.yaml

Filename based on compatible, so qcom,msm8976-ramp-controller.yaml

> 
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,ramp-controller.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,ramp-controller.yaml
> new file mode 100644
> index 000000000000..95ce48cfca4e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,ramp-controller.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/soc/qcom/qcom,ramp-controller.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"

Drop quotes from both lines above.

> +
> +title: Qualcomm Ramp Controller
> +
> +maintainers:
> +  - AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> +
> +description:
> +  The Ramp Controller is used to program the sequence ID for pulse
> +  swallowing, enable sequences and linking Sequence IDs (SIDs) for

s/linking/link/ if I understand the sentence correctly (is used to:
program, enable and link)

> +  the CPU cores on some Qualcomm SoCs.
> +
> +properties:
> +  compatible:
> +    items:

Drop items.

> +      enum:

I also think you did not test it...

> +        - qcom,msm8976-ramp-controller
> +
> +  reg:
> +    maxItems: 1
> +

Best regards,
Krzysztof