linux-kernel - Re: [PATCH 2/2] soc: qcom: Add Qualcomm Ramp Controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f3783a1-5e70-394d-1218-5969fb08c9c8@collabora.com>
Date:   Fri, 4 Nov 2022 15:24:41 +0100
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        agross@...nel.org
Cc:     andersson@...nel.org, konrad.dybcio@...ainline.org,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, marijn.suijten@...ainline.org,
        kernel@...labora.com,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...ainline.org>
Subject: Re: [PATCH 2/2] soc: qcom: Add Qualcomm Ramp Controller driver

Il 04/11/22 15:22, Krzysztof Kozlowski ha scritto:
> On 04/11/2022 10:18, AngeloGioacchino Del Regno wrote:
>> Il 04/11/22 15:04, Krzysztof Kozlowski ha scritto:
>>> On 04/11/2022 09:35, AngeloGioacchino Del Regno wrote:
>>>> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...ainline.org>
>>>>
>>>> The Ramp Controller is used to program the sequence ID for pulse
>>>> swallowing, enable sequence and linking sequence IDs for the CPU
>>>> cores on some Qualcomm SoCs.
>>>>
>>>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...ainline.org>
>>>> ---
>>>>    drivers/soc/qcom/Kconfig           |   9 +
>>>>    drivers/soc/qcom/Makefile          |   1 +
>>>>    drivers/soc/qcom/ramp_controller.c | 330 +++++++++++++++++++++++++++++
>>>>    3 files changed, 340 insertions(+)
>>>>    create mode 100644 drivers/soc/qcom/ramp_controller.c
>>>>
>>>> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
>>>> index 024e420f1bb7..1e681f98bad4 100644
>>>> --- a/drivers/soc/qcom/Kconfig
>>>> +++ b/drivers/soc/qcom/Kconfig
>>>> @@ -95,6 +95,15 @@ config QCOM_QMI_HELPERS
>>>>    	tristate
>>>>    	depends on NET
>>>>    
>>>> +config QCOM_RAMP_CTRL
>>>> +	tristate "Qualcomm Ramp Controller driver"
>>>> +	depends on ARCH_QCOM
>>>
>>> I propose:
>>> depends on ARCH_QCOM && ARM || COMPILE_TEST
>>>
>>> I don't think it is used on ARM64 SoCs, so let's make life of distros
>>> easier.
>>
>> Forgot to reply to this one: MSM8956 and MSM8976 are ARM64 SoCs :-)
> 
> Yeah, indeed, I meant the other way around, so && ARM&64 :)
> 

I went too fast and sent out a v2 with ARCH_QCOM || COMPILE_TEST....
....should I go for a v3?

Cheers,
Angelo