linux-kernel - Re: [PATCH v3] random: do not include <asm/archrandom.h> from random.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y2Ui3fr7pwKGJzM3@osiris>
Date:   Fri, 4 Nov 2022 15:34:05 +0100
From:   Heiko Carstens <hca@...ux.ibm.com>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] random: do not include <asm/archrandom.h> from
 random.h

On Thu, Nov 03, 2022 at 01:17:40PM +0100, Jason A. Donenfeld wrote:
> The <asm/archrandom.h> header is a random.c private detail, not
> something to be called by other code. As such, don't make it
> automatically available by way of random.h.
> 
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Cc: Heiko Carstens <hca@...ux.ibm.com>
> Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu>
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>
> ---
>  arch/powerpc/kernel/setup-common.c | 1 +
>  arch/s390/kernel/setup.c           | 1 +
>  drivers/char/hw_random/s390-trng.c | 1 +
>  drivers/char/random.c              | 1 +
>  include/linux/random.h             | 2 --
>  5 files changed, 4 insertions(+), 2 deletions(-)

Acked-by: Heiko Carstens <hca@...ux.ibm.com>