linux-kernel - Re: [PATCH] dmaengine: fsl-edma: fix potential NULL pointer dereference in fsl_edma_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y2UjqrTVMKm1QGmD@matsya>
Date:   Fri, 4 Nov 2022 20:07:30 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Andrew Chernyakov <acherniakov@...ralinux.ru>
Cc:     dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        lvc-project@...uxtesting.org
Subject: Re: [PATCH] dmaengine: fsl-edma: fix potential NULL pointer
 dereference in fsl_edma_tx_status()

On 26-10-22, 13:18, Andrew Chernyakov wrote:
> fsl_edma_desc_residue() dereferences fsl_chan->edesc, but it is checked
> for NULL only in one of two places where fsl_edma_desc_residue() is
> called from fsl_edma_tx_status().

Patch subject should be the change it introduces, pls revise

> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Andrew Chernyakov <acherniakov@...ralinux.ru>
> ---
>  drivers/dma/fsl-edma-common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/fsl-edma-common.c b/drivers/dma/fsl-edma-common.c
> index a06a1575a2a5..fb712d85d556 100644
> --- a/drivers/dma/fsl-edma-common.c
> +++ b/drivers/dma/fsl-edma-common.c
> @@ -330,7 +330,7 @@ enum dma_status fsl_edma_tx_status(struct dma_chan *chan,
>  	if (fsl_chan->edesc && cookie == fsl_chan->edesc->vdesc.tx.cookie)
>  		txstate->residue =
>  			fsl_edma_desc_residue(fsl_chan, vdesc, true);
> -	else if (vdesc)
> +	else if (fsl_chan->edesc && vdesc)
>  		txstate->residue =
>  			fsl_edma_desc_residue(fsl_chan, vdesc, false);
>  	else
> -- 
> 2.35.1

-- 
~Vinod