linux-kernel - Re: [PATCH v2 07/15] MIPS: IP27: clean out sn/nmi.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 4 Nov 2022 15:50:02 +0100
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Ahelenia Ziemiańska 
        <nabijaczleweli@...ijaczleweli.xyz>
Cc:     Jonathan Corbet <corbet@....net>,
        Federico Vaga <federico.vaga@...a.pv.it>,
        Alex Shi <alexs@...nel.org>,
        Yanteng Si <siyanteng@...ngson.cn>,
        Hu Haowen <src.res@...il.cn>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        linux-doc-tw-discuss@...ts.sourceforge.net,
        linux-mips@...r.kernel.org
Subject: Re: [PATCH v2 07/15] MIPS: IP27: clean out sn/nmi.h

On Wed, Nov 02, 2022 at 12:05:30AM +0100, Ahelenia Ziemiańska wrote:
> The only user is arch/mips/sgi-ip27/ip27-nmi.c; this file was imported
> wholesale in 2.3.99pre9-1, and received only whitespace updates since
> then.
> 
> NMI_MAGIC isn't a magic number; it's unclear if it's actually used by
> the firmware in some capacity or if it's a holdover from copying the SGI
> code, but in the former case it's API and in the latter it's dead cruft.

it's used by firmware and Linux code to register the NMI exception
handler. Please leave arch/mips/include/asm/sn/nmi.h untouched as
it's documents firmware NMI handler usage (even when we don't use it, yet).

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]