[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e17dbc8c-b2ba-6acf-7b56-85a246aaa765@linaro.org>
Date: Fri, 4 Nov 2022 11:14:12 -0400
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Thippeswamy Havalige <thippeswamy.havalige@....com>,
linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org
Cc: bhelgaas@...gle.com, michals@...inx.com, robh+dt@...nel.org,
nagaradhesh.yeleswarapu@....com, bharat.kumar.gogada@....com
Subject: Re: [PATCH v3 1/2] dt-bindings: PCI: xilinx-pcie: Convert to YAML
schemas of Xilinx AXI PCIe Root Port Bridge
On 04/11/2022 00:41, Thippeswamy Havalige wrote:
> Convert to YAML dtschemas of Xilinx AXI PCIe Root Port Bridge
> dt binding.
>
> Signed-off-by: Thippeswamy Havalige <thippeswamy.havalige@....com>
> ---
> +
> +title: Xilinx AXI PCIe Root Port Bridge
> +
> +maintainers:
> + - Thippeswamy Havalige <thippeswamy.havalige@....com>
> +
> +allOf:
> + - $ref: /schemas/pci/pci-bus.yaml#
> +
> +properties:
> + compatible:
> + const: xlnx,axi-pcie-host-1.00.a
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + ranges:
> + items:
> + - description: |
> + ranges for the PCI memory regions (I/O space region is not
> + supported by hardware)
> +
> + "#interrupt-cells":
> + const: 1
> +
> + interrupt-controller:
> + description: identifies the node as an interrupt controller
> + type: object
> + properties:
> + interrupt-controller: true
> +
> + "#address-cells":
> + const: 0
> +
> + "#interrupt-cells":
> + const: 1
> +
> + required:
> + - 'interrupt-controller'
> + - '#address-cells'
> + - '#interrupt-cells'
Use same style of quotes as in other places, either ' or "
> +
> + additionalProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - ranges
> + - interrupts
> + - interrupt-map
> + - "#interrupt-cells"
> + - interrupt-controller
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + pcie@...00000 {
> + compatible = "xlnx,axi-pcie-host-1.00.a";
> + reg = < 0x50000000 0x1000000 >;
Still wrong - no spaces around <>
Best regards,
Krzysztof
Powered by blists - more mailing lists